Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add code to containers check to allow users to silence it #42501

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add code to containers check to allow users to silence it #42501

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
12db661
add code to containers check to allow users to silence it
baronfel Aug 1, 2024
602ea23
Merge branch 'main' into assign-code-for-containers-warning
baronfel Aug 21, 2024
140e43c
Merge branch 'main' into assign-code-for-containers-warning
baronfel Sep 5, 2024
f6a77a9
Merge branch 'main' into assign-code-for-containers-warning
baronfel Sep 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/Containers/Microsoft.NET.Build.Containers/KnownStrings.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,14 @@ public static class Items

public static class ErrorCodes
{
// current version doesn't support containerization
public static readonly string CONTAINER002 = nameof(CONTAINER002);
// containerimagename rename
public static readonly string CONTAINER003 = nameof(CONTAINER003);
// generic http error
public static readonly string CONTAINER004 = nameof(CONTAINER004);
// don't use the containers package
public static readonly string CONTAINER005 = nameof(CONTAINER005);
MiYanni marked this conversation as resolved.
Show resolved Hide resolved
public static readonly string CONTAINER1011 = nameof(CONTAINER1011);
public static readonly string CONTAINER1012 = nameof(CONTAINER1012);
public static readonly string CONTAINER1013 = nameof(CONTAINER1013);
Expand Down
1 change: 1 addition & 0 deletions src/Containers/packaging/build/Microsoft.NET.Build.Containers.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,7 @@
($(_SdkCanPublishWorker) and $(_IsWorkerProject)) or
($(_SdkCanPublishConsole) and '$(EnableSdkContainerSupport)' == 'true')
)"
Code="CONTAINER005"
Text="The $(_ContainersPackageIdentity) NuGet package is explicitly referenced but the current SDK can natively publish the project as a container. Consider removing the package reference to $(_ContainersPackageIdentity) because it is no longer needed." />

<PropertyGroup>
Expand Down
Loading