Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Permit workload restore to work with new global.json #42606

Merged
merged 8 commits into from
Aug 28, 2024
Merged

Permit workload restore to work with new global.json #42606

merged 8 commits into from
Aug 28, 2024

Commits on Aug 7, 2024

  1. Permit workload restore to work with new global.json 

    Specifying a workload set version in the global.json file is a supported scenario. If that workload set has not yet been installed, and the user tries to take an action that relies on workloads, we should error and indicate that they should make sure that workload set is installed first via update, install, or restore. We do that correctly, but when the user subsequently restores, we do not escape from the error case and instead direct the user to run restore. We should handle it properly, essentially installing the workload set before we discover which workloads the user needs and installing those.
    @Forgind
    Forgind committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    0a2e4c1 View commit details
    Browse the repository at this point in the history

  2. move up workload history recorder

    @Forgind
    Forgind committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    e963dec View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2024

  1. Permit workload restore to work with new global.json 

    Specifying a workload set version in the global.json file is a supported scenario. If that workload set has not yet been installed, and the user tries to take an action that relies on workloads, we should error and indicate that they should make sure that workload set is installed first via update, install, or restore. We do that correctly, but when the user subsequently restores, we do not escape from the error case and instead direct the user to run restore. We should handle it properly, essentially installing the workload set before we discover which workloads the user needs and installing those.
    @Forgind
    Forgind committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    c8dacc6 View commit details
    Browse the repository at this point in the history

  2. move up workload history recorder

    @Forgind
    Forgind committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    9840fbd View commit details
    Browse the repository at this point in the history

  3. Comments

    @Forgind
    Forgind committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    8e820df View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2024

  1. Merge branch 'fix-restore-error' of https://github.com/Forgind/sdk in… 

    …to fix-restore-error
    @Forgind
    Forgind committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    4c367f6 View commit details
    Browse the repository at this point in the history

  2. Remove WouldThrowException

    @Forgind
    Forgind committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    2fd02c7 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2024

  1. Harden against double-install

    @Forgind
    Forgind committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    58ffe11 View commit details
    Browse the repository at this point in the history