Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/9.0.1xx] Extend dotnet run to invoke a run-command-producing Target #42987

Merged
merged 41 commits into from
Aug 26, 2024
Merged

[release/9.0.1xx] Extend dotnet run to invoke a run-command-producing Target #42987

merged 41 commits into from
Aug 26, 2024

Commits on Aug 23, 2024

  1. refactor for readability before starting work

    @baronfel
    baronfel authored and github-actions committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    fe3257b View commit details
    Browse the repository at this point in the history

  2. simple execution of new target during run evaluation

    @baronfel
    baronfel authored and github-actions committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    c51f319 View commit details
    Browse the repository at this point in the history

  3. refactor to push validation into S.CL instead of in Execute

    @baronfel
    baronfel authored and github-actions committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    f4f6efa View commit details
    Browse the repository at this point in the history

  4. refactor to use FileINfo to reduce bugs froim using just String

    @baronfel
    baronfel authored and github-actions committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    587dcb7 View commit details
    Browse the repository at this point in the history

  5. Revert "refactor to use FileINfo to reduce bugs froim using just String" 

    This reverts commit 0f4a7fd.
    @baronfel
    baronfel authored and github-actions committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    fa05cb1 View commit details
    Browse the repository at this point in the history

  6. fix directory resolution bug

    @baronfel
    baronfel authored and github-actions committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    fe3d1c2 View commit details
    Browse the repository at this point in the history

  7. add ProjectCapability for ProjectSystem compatibility checking

    @baronfel
    baronfel authored and github-actions committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    5d92fb2 View commit details
    Browse the repository at this point in the history

  8. Revert back to some prior less-strict handling to green up existing t… 

    …ests
    @baronfel
    baronfel authored and github-actions committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    2a2f85e View commit details
    Browse the repository at this point in the history

  9. Correct dotnet-watch dependency 

    I put the dependency on the top-level target, but since the Run target is only valid for a single TFM it needs to be on the 'per-framework' inner build target.
    @baronfel
    baronfel authored and github-actions committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    2fb3829 View commit details
    Browse the repository at this point in the history

  10. Fix run parsing tests to have a valid project file even if not direct… 

    …ly specified
    @baronfel
    baronfel authored and github-actions committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    c019b1f View commit details
    Browse the repository at this point in the history

  11. Fix dotnet run tests to account for expected restore args

    @baronfel
    baronfel authored and github-actions committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    953e9b0 View commit details
    Browse the repository at this point in the history

  12. Make tests that check for -p project file usage green up

    @baronfel
    baronfel authored and github-actions committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    5c512f7 View commit details
    Browse the repository at this point in the history

  13. generate binlogs as we're testing things out

    @baronfel
    baronfel authored and github-actions committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    af9f51c View commit details
    Browse the repository at this point in the history

  14. remove dotnet-watch precompute hook since watch no longer gets run ar… 

    …guments
    @baronfel
    baronfel authored and github-actions committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    298cc71 View commit details
    Browse the repository at this point in the history

  15. Fix dependent ordering of argument parsing

    @baronfel
    baronfel authored and github-actions committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    2af52dc View commit details
    Browse the repository at this point in the history

  16. Fix run parsing tests in a way that doesn't impact other parsing tests.

    @baronfel
    baronfel authored and github-actions committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    f1a6379 View commit details
    Browse the repository at this point in the history

  17. Update expectations since we emit long-forms for forwarded properties

    @baronfel
    baronfel authored and github-actions committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    2a202ae View commit details
    Browse the repository at this point in the history

  18. Remove test that has odd side effect behavior

    @baronfel
    baronfel authored and github-actions committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    b0c02af View commit details
    Browse the repository at this point in the history

  19. Ensure that we check project applicability to validate conditions

    @baronfel
    baronfel authored and github-actions committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    02afed7 View commit details
    Browse the repository at this point in the history

  20. quick change to green up parser -- test

    @baronfel
    baronfel authored and github-actions committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    bc99659 View commit details
    Browse the repository at this point in the history

  21. Refactor parsing tests to make them not clobber

    @baronfel
    baronfel authored and github-actions committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    72ac23c View commit details
    Browse the repository at this point in the history

  22. Make test invocations more isolated

    @baronfel
    baronfel authored and github-actions committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    308202b View commit details
    Browse the repository at this point in the history

  23. Add test cases and error handling

    @baronfel
    baronfel authored and github-actions committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    af9856b View commit details
    Browse the repository at this point in the history

  24. Create a terminal logger for evaluation-time errors

    @baronfel
    baronfel authored and github-actions committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    82ae798 View commit details
    Browse the repository at this point in the history

  25. Fix verbosity check that tests caught

    @baronfel
    baronfel authored and github-actions committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    c8be312 View commit details
    Browse the repository at this point in the history

  26. Strip nonvisible terminal logger progress indicators when comparing o… 

    …utputs
    @baronfel
    baronfel authored and github-actions committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    74530ec View commit details
    Browse the repository at this point in the history

  27. disable test and log issue to reenable

    @baronfel
    baronfel authored and github-actions committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    e5ede47 View commit details
    Browse the repository at this point in the history

  28. Try to work around errors parsing stdout from the application being run

    @baronfel
    baronfel authored and github-actions committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    8c31d90 View commit details
    Browse the repository at this point in the history

  29. Safely parse stdout

    @baronfel
    baronfel authored and github-actions committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    c3fa9d6 View commit details
    Browse the repository at this point in the history

  30. Unify TerminalLogger progress stripping code

    @baronfel
    baronfel authored and github-actions committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    3243d64 View commit details
    Browse the repository at this point in the history

  31. green up watch tests by fixing stdout parsing

    @baronfel
    baronfel authored and github-actions committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    8ad26a1 View commit details
    Browse the repository at this point in the history

  32. Skip globbing test that works locally but fails in CI.

    @baronfel
    baronfel authored and github-actions committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    8d1aadc View commit details
    Browse the repository at this point in the history

  33. Fix a few more stdout-parsing issues in the dotnet run tests

    @baronfel
    baronfel authored and github-actions committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    29dcf1a View commit details
    Browse the repository at this point in the history

  34. disable one more test that works on local testing

    @baronfel
    baronfel authored and github-actions committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    311c7d9 View commit details
    Browse the repository at this point in the history

  35. disable one more test that works on local testing

    @baronfel
    baronfel authored and github-actions committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    cf42402 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2024

  1. Update GlobbingAppTests.cs 

    Skip another intermittently failing test.
    @baronfel
    baronfel committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    a6fdd1c View commit details
    Browse the repository at this point in the history

  2. Update GlobbingAppTests.cs

    @baronfel
    baronfel committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    2798856 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2024

  1. Update GlobbingAppTests.cs

    @baronfel
    baronfel committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    229e3ce View commit details
    Browse the repository at this point in the history

  2. Update watch tests

    @baronfel
    baronfel committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    7421d2f View commit details
    Browse the repository at this point in the history

  3. fix regression in --property forwarding with an invalid argument (#43004 

    )
    @baronfel
    baronfel committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    6179993 View commit details
    Browse the repository at this point in the history

  4. More flaky tests

    @baronfel
    baronfel committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    e560ac5 View commit details
    Browse the repository at this point in the history