Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic guidelines for telemetry usage for tooling authors #43097

Merged
merged 6 commits into from
Sep 9, 2024

Conversation

baronfel
Copy link
Member

No description provided.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Aug 29, 2024
@baronfel baronfel requested a review from a team August 30, 2024 01:33
@dsplaisted
Copy link
Member

If a component is shipped in the .NET SDK, then any telemetry it sends should be included in the documented data points, right? That should also probably be mentioned in this doc.

@baronfel
Copy link
Member Author

This is more about random MSBuild SDKs and NuGet Packages - I had some internal teams reach out to me about how to integrate their telemetry with the SDK and we explicitly do not want that kind of integrated telemetry, but I didn't have a doc to point to. I'd expect other teams to have their own telemetry declarations that they need to stay on top of.

@baronfel
Copy link
Member Author

baronfel commented Sep 5, 2024

Thanks for the notes Yanni - applied them, I'll merge this once the builds finish

@joeloff
Copy link
Member

joeloff commented Sep 6, 2024

@baronfel Anyone forking and building this repo would automatically end up with the MS privacy policy links, etc. Do we need to clarify that someone that forks, builds and redistribute their own copy of the SDK should not only change the telemetry model, but probably also replace the privacy policy links with their own. We should probably also check whether it's possible to add additional policies, e.g. if some adds a new SDK or tools that are governed by a more specific policy than our general one. We've had really specialized EULAs before that were extremely specific and I wonder if that's true for privacy policies too.

@baronfel
Copy link
Member Author

baronfel commented Sep 6, 2024

@joeloff maybe? It seems like that would be part of a greater "build your own SDK" checklist, and that list would be better served being located at the place where the SDK constructions actually happen - e.g dotnet/source-build or dotnet/dotnet. What do you think?

@joeloff
Copy link
Member

joeloff commented Sep 6, 2024

@joeloff maybe? It seems like that would be part of a greater "build your own SDK" checklist, and that list would be better served being located at the place where the SDK constructions actually happen - e.g dotnet/source-build or dotnet/dotnet. What do you think?

Yes, a more central place would make sense for that case.

@baronfel baronfel merged commit 37a14b1 into dotnet:main Sep 9, 2024
37 checks passed
@baronfel baronfel deleted the doc-telemetry-guidelines branch September 9, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants