Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dotnet test protocol messages #43226

Conversation

mariam-abdulla
Copy link
Member

@mariam-abdulla mariam-abdulla commented Sep 4, 2024

This pull request includes several changes to the dotnet-test command in the src/Cli/dotnet/commands/dotnet-test directory. The key changes involve renaming classes and records for better consistency, updating event arguments to include additional properties, and reorganizing some files and serializers.

Renaming for Consistency:

  • internal static class HandshakeInfoPropertyNames was renamed to HandshakeMessagePropertyNames in CliConstants.cs.
  • HandshakeInfoArgs was renamed to HandshakeArgs and HandshakeInfo property was renamed to Handshake in CustomEventArgs.cs.
  • HandshakeInfo record was renamed to HandshakeMessage in HandshakeMessage.cs.
  • Module record was renamed to ModuleMessage in ModuleMessage.cs.

Event Arguments Update:

  • HelpEventArgs now includes ModulePath and CommandLineOptions properties in CustomEventArgs.cs.
  • DiscoveredTestEventArgs now includes ExecutionId and DiscoveredTests properties in CustomEventArgs.cs.
  • TestResultEventArgs now includes ExecutionId, SuccessfulTestResults, and FailedTestResults properties in CustomEventArgs.cs.
  • FileArtifactEventArgs now includes ExecutionId and FileArtifacts properties in CustomEventArgs.cs.

Records and Serializers:

  • CommandLineOptionMessage record no longer implements IRequest in CommandLineOptionMessages.cs.
  • DiscoveredTestMessage record was split into DiscoveredTestMessage and DiscoveredTestMessages in DiscoveredTestMessages.cs.
  • FileArtifactInfo record was replaced with FileArtifactMessage and FileArtifactMessages in FileArtifactMessages.cs.
  • SuccessfulTestResultMessage and FailedTestResultMessage were combined into TestResultMessages in TestResultMessages.cs.

Object Field IDs:

  • Updated field IDs and added new ones for DiscoveredTestMessages, TestResultMessages, and FileArtifactMessages in ObjectFieldIds.cs.

Serializers:

  • Updated CommandLineOptionMessagesSerializer to fix field count calculation and field naming conventions in CommandLineOptionMessagesSerializer.cs [1] [2].
  • Removed DiscoveredTestMessageSerializer and added DiscoveredTestMessagesSerializer in DiscoveredTestMessagesSerializer.cs.

@mariam-abdulla mariam-abdulla requested a review from a team as a code owner September 4, 2024 12:58
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-DotNet Test untriaged Request triage from a team member labels Sep 4, 2024
@mariam-abdulla mariam-abdulla removed the untriaged Request triage from a team member label Sep 4, 2024
@mariam-abdulla mariam-abdulla merged commit 8d10b56 into main Sep 9, 2024
37 checks passed
@mariam-abdulla mariam-abdulla deleted the dev/mabdullah/UpdateToListOfMessagesInProtocolInDotnetTest branch September 9, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants