Update dotnet test protocol messages #43226
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
dotnet-test
command in thesrc/Cli/dotnet/commands/dotnet-test
directory. The key changes involve renaming classes and records for better consistency, updating event arguments to include additional properties, and reorganizing some files and serializers.Renaming for Consistency:
internal static class HandshakeInfoPropertyNames
was renamed toHandshakeMessagePropertyNames
inCliConstants.cs
.HandshakeInfoArgs
was renamed toHandshakeArgs
andHandshakeInfo
property was renamed toHandshake
inCustomEventArgs.cs
.HandshakeInfo
record was renamed toHandshakeMessage
inHandshakeMessage.cs
.Module
record was renamed toModuleMessage
inModuleMessage.cs
.Event Arguments Update:
HelpEventArgs
now includesModulePath
andCommandLineOptions
properties inCustomEventArgs.cs
.DiscoveredTestEventArgs
now includesExecutionId
andDiscoveredTests
properties inCustomEventArgs.cs
.TestResultEventArgs
now includesExecutionId
,SuccessfulTestResults
, andFailedTestResults
properties inCustomEventArgs.cs
.FileArtifactEventArgs
now includesExecutionId
andFileArtifacts
properties inCustomEventArgs.cs
.Records and Serializers:
CommandLineOptionMessage
record no longer implementsIRequest
inCommandLineOptionMessages.cs
.DiscoveredTestMessage
record was split intoDiscoveredTestMessage
andDiscoveredTestMessages
inDiscoveredTestMessages.cs
.FileArtifactInfo
record was replaced withFileArtifactMessage
andFileArtifactMessages
inFileArtifactMessages.cs
.SuccessfulTestResultMessage
andFailedTestResultMessage
were combined intoTestResultMessages
inTestResultMessages.cs
.Object Field IDs:
DiscoveredTestMessages
,TestResultMessages
, andFileArtifactMessages
inObjectFieldIds.cs
.Serializers:
CommandLineOptionMessagesSerializer
to fix field count calculation and field naming conventions inCommandLineOptionMessagesSerializer.cs
[1] [2].DiscoveredTestMessageSerializer
and addedDiscoveredTestMessagesSerializer
inDiscoveredTestMessagesSerializer.cs
.