Correctly handle different architectures for devdeviceID #43471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the test to ensure we have caching
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
|
Test failures are the known container failures. |
…he 64bit hive on x64 and arm64 and the x86 hive on x86
nagilson
approved these changes
Sep 17, 2024
…to 32bit when on a 32bit OS
baronfel
approved these changes
Sep 17, 2024
|
/backport to release/9.0.1xx-rc2 |
|
Started backporting to release/9.0.1xx-rc2: https://github.com/dotnet/sdk/actions/runs/10911658029 |
marcpopMSFT
changed the title
marcpopMSFT
added
Servicing-approved
and removed
Servicing-consider
untriaged
marcpopMSFT
added a commit
that referenced
this pull request
Oct 4, 2024
marcpopMSFT
added a commit
that referenced
this pull request
Oct 4, 2024
marcpopMSFT
added a commit
that referenced
this pull request
Oct 4, 2024
This was referenced Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
DevDeviceID was introduced in RC2 as a way to be consistent with Visual Studio on how to track individual devices. There was a bug in the initial implementation where on windows, we would use the SDK architecture version of the registry for reading and storing the cached value
Customer Impact
x86 SDKs would have a completely unique devdevice ID to the x64 version on the same box. The spec calls for the same id regardless of architecture.
Regression
No, implemented incorrectly.
Testing
Minimal. Update the test to ensure we have caching
Risk
Very low