-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change from "sln" to "solution" as primary, and add "sln" as alias #43607
Merged
nagilson
merged 23 commits into
dotnet:main
from
SourceCodeWhen:ChangeSlnToSolutionWithAlias
Oct 18, 2024
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
8ea8db8
Change to make "solution" the primary command for SlnCommand and "sln…
SourceCodeWhen 75ae26a
Add additional command test change to fit new primary command name.
SourceCodeWhen 0b0a886
Update top level command test
SourceCodeWhen 50d5ad3
Add change for solution in show help code.
SourceCodeWhen 69627b6
Telemetry change to solution as hashed value. Possible issue with thi…
SourceCodeWhen b592f4b
Add in sln so the alias gets correctly represented in desired topleve…
SourceCodeWhen 8748c88
Merge branch 'main' into ChangeSlnToSolutionWithAlias
SourceCodeWhen 99df58a
Merge branch 'dotnet:main' into ChangeSlnToSolutionWithAlias
SourceCodeWhen 4dedcc9
Fix: Remove unnecessary for loop
73bea80
Added extra parameterse for solution command to existing tests
c21feac
Add parameters for solution command to existing tests
ef56395
Added new parameters to tests for solution command
dc99c17
Fix: Modify test filenames to point to correct place
be0969d
Merge branch 'main' into ChangeSlnToSolutionWithAlias
nagilson 9057d37
Merge branch 'main' into ChangeSlnToSolutionWithAlias
nagilson 9771993
Merge branch 'main' into ChangeSlnToSolutionWithAlias
SourceCodeWhen 9a09b89
Merge branch 'main' into ChangeSlnToSolutionWithAlias
nagilson 4f68719
Fix: test parameters passed to copytestasset
522cf0e
Fix: test parameters passed to copytestasset
cc86058
Merge branch 'main' into ChangeSlnToSolutionWithAlias
SourceCodeWhen 48553c1
Merge branch 'main' into ChangeSlnToSolutionWithAlias
SourceCodeWhen 600e6d6
Merge branch 'main' into ChangeSlnToSolutionWithAlias
nagilson 528ec3d
Merge branch 'main' into ChangeSlnToSolutionWithAlias
nagilson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shouldn't change if the sln parameter on this function is not changing.