Add missing conditions for illumos #43775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
am11
commented
Sep 28, 2024
•
am11
commented
- Add missing illumos and solaris conditions
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
am11
force-pushed
the
feature/build-illumos
branch
from
c77601c
to
35f84b9
Compare
am11
force-pushed
the
feature/build-illumos
branch
from
35f84b9
to
6c4b2aa
Compare
am11
commented
Sep 29, 2024
|
cc @akoeplinger |
am11
commented
Sep 29, 2024
akoeplinger
reviewed
Oct 2, 2024
Open
3 tasks
|
Remaining failures seem unrelated. |
|
@akoeplinger, do you have a specific platform in mind that you think we should test, especially one that might be impacted by this change? Also, I've noticed several stale conditions that could be cleaned up. I've focused on those that unblock illumos/solaris in a more generic and future-proof way. |
|
@am11 I don't have enough context on how we calculate these RIDs so I'd appreciate if someone from the source-build team could take a look. That said, the current failures do seem related. |
|
I have rolled it back to hardcoded names. Was trying to avoid that, but seems like we are missing some context here to pull off that kind of refactoring in the same go.. |
MichaelSimons
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.