Use non-stable SDK version for SB artifacts #44362
Conversation
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
| <UsingTask TaskName="IndexItemGroup" TaskFactory="RoslynCodeTaskFactory" AssemblyFile="$(MSBuildToolsPath)\Microsoft.Build.Tasks.Core.dll" > | ||
| <ParameterGroup> | ||
| <Items Required="true" ParameterType="Microsoft.Build.Framework.ITaskItem[]"/> | ||
| <Index Required="true" ParameterType="System.Int32"/> | ||
| <Item Output="true" ParameterType="Microsoft.Build.Framework.ITaskItem"/> | ||
| </ParameterGroup> | ||
| <Task> | ||
| <Code Type="Fragment" Language="cs"> | ||
| <![CDATA[Item = Items[ Index ];]]> | ||
| </Code> | ||
| </Task> | ||
| </UsingTask> |
There was a problem hiding this comment.
I think this would be our first inline C# msbuild task. Could we just a regex pattern below which is already natively supported as an msbuild function?
There was a problem hiding this comment.
Actually, I see that you just want to read a specific line. I think that should already be supported in msbuild without a task. cc @rainersigwald
There was a problem hiding this comment.
Also see https://stackoverflow.com/questions/29403937/is-there-an-indexer-available-in-msbuild-itemgroups (the Edit part in the initial comment)
There was a problem hiding this comment.
We do use inline msbuild tasks in other places, in VMR. But, I like the idea of avoiding the task if possible - will check the other suggested solution.
There was a problem hiding this comment.
Sounds good. Are you sure that the VMR uses inline tasks? I can't find any hits: https://github.com/search?q=repo%3Adotnet%2Fsdk%20RoslynCodeTaskFactory&type=code
There was a problem hiding this comment.
Fixed with 2c1e9e2
There was a problem hiding this comment.
There was a problem hiding this comment.
OK I thought you meant our infra that we own, the VMR orchestrator, That one is a workaround thing that will be removed again in ~ a month.
| <Output PropertyName="SourceBuiltSdkNonStableVersion" TaskParameter="Item"/> | ||
| </IndexItemGroup> | ||
| <PropertyGroup> | ||
| <SourceBuiltSdkNonStableVersion>$([System.Text.RegularExpressions.Regex]::Split('$([System.IO.File]::ReadAllText('%(SdkVersionFileItem.Identity)'))', '\r\n|\r|\n')[3])</SourceBuiltSdkNonStableVersion> |
There was a problem hiding this comment.
Can ReadAllLines be used instead to simplify the logic?
There was a problem hiding this comment.
I could not get ReadAllLines to work in MSBuild: error MSB4185: The function "ReadAllLines" on type "System.IO.File" is not available for execution as an MSBuild property function
There is a built-in task as an alternative - ReadLinesFromFile. But, then the code gets a bit larger.
There was a problem hiding this comment.
Yeah not sure why we allow ReadAllText but not ReadAllLines; I'd be willing to expand that if you care to file it. But this seems ok (or using string.Split()).
|
Validation build was successful. |
Fixes: dotnet/source-build#4682
Due to several changes made early in 9.0, particularly dotnet/installer#18153, we're versioning GA and Servicing source-build packages with SDK's stable version. This was a result of a switch to not use the version from the intermediate package, which was always of non-stable kind. We're now using the version in sdk tarballs filename, which is always stable for GA and during servicing.
The fix is to obtain the non-stable version from SDK's
.versionfile.Currently, in failing 9.0 VMR build:
With this fix:
This also updates the content of the
.versionfile inPrivate.SourceBuilt.Artifacts.*package, to use the non-stable version. This matches the expected experience from previous releases, i.e. 8.0 GA.8.0 RTM and GA packages, for comparison, can be obtained from links in following PRs: dotnet/installer#17784, dotnet/installer#20172