Invoke dotnet nuget why directly through API #44614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
baronfel
reviewed
Nov 4, 2024
|
I looked at this and the changes look reasonable as far as the NuGet side goes. |
3 tasks
|
I'm guessing this PR was accidentally closed by GH's keywords, but it's actually something that needs to be reopened, right @zivkan |
zivkan
force-pushed
the
dotnet-nuget-why-command
branch
2 times, most recently
from
30f49f9 to
e34bb9e
Compare
zivkan
force-pushed
the
dotnet-nuget-why-command
branch
from
e34bb9e to
bbfcb2a
Compare
|
@dotnet/nuget-team @dotnet/dotnet-cli This PR was opened a while ago, but it's ready for review now, please. It would be nice to get in time for 9.0.200. The Mac test job appears to be timing out on all builds/prs, so I assume it's not a blocking issue for this PR. |
baronfel
approved these changes
Dec 18, 2024
nkolev92
approved these changes
Dec 19, 2024
Nigusu-Allehu
approved these changes
Dec 19, 2024
This was referenced Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial version of
dotnet nuget whyrequired two arguments, the first being the solution, project, or directory to run as. In NuGet/NuGet.Client#5969 I made it optional, using the current directory when not provided. However, this repo has a duplicate of the CLI parser to aid tab-completion. Therefore, even when the command works, there's an error message:Following NuGet/NuGet.Client#6118, this PR changes the dotnet CLI to get the CLI parser from NuGet directly (this command uses System.CommandLine), so
dotnet nuget whyno longer needs to be invoked though the NuGet.CommandLine.XPlat console app. Therefore, any future changes todotnet nuget whywill apply automatically on NuGet insertion, rather than needing duplicate CLI parsing changes in both repos.