Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use WebAssemblyHotReloadCapabilities project property #45055

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Use WebAssemblyHotReloadCapabilities project property #45055

merged 1 commit into from
Dec 2, 2024

Conversation

tmat
Copy link
Member

@tmat tmat commented Nov 23, 2024 •
edited
Loading

... to determine WASM capabilities instead of querying the runtime, which might not be loaded yet.

Contributes to a fix of dotnet/aspnetcore#59027
Related: dotnet/aspnetcore#59094

@tmat
Use WebAssemblyHotReloadCapabilities project property
4d05d83 
... to determine WASM capabilities instead of querying the runtime, which might not be loaded yet.
@tmat tmat requested a review from a team as a code owner November 23, 2024 00:28
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch untriaged Request triage from a team member labels Nov 23, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Thanks for your PR, @tmat.
To learn about the PR process and branching schedule of this repo, please take a look at the SDK PR Guide.

@tmat
Copy link
Member Author

tmat commented Nov 23, 2024

@phil-allen-msft ptal

@tmat tmat merged commit b5757e5 into dotnet:release/9.0.2xx Dec 2, 2024
31 checks passed
@tmat tmat deleted the WasmCapabilities branch December 2, 2024 21:30
@v-wuzhai v-wuzhai mentioned this pull request Dec 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-allen-msft phil-allen-msft phil-allen-msft approved these changes

Assignees
No one assigned
Labels
Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmat @phil-allen-msft