Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/9.0.2xx] Update dependencies from dotnet/msbuild #45405

Open
wants to merge 4 commits into
base: release/9.0.2xx
Choose a base branch
from
Open

[release/9.0.2xx] Update dependencies from dotnet/msbuild #45405

wants to merge 4 commits into from
+9 −12

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Dec 10, 2024 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/msbuild

  • Subscription: ec91df1d-8e6d-40cf-80b3-4ef102298e66
  • Build: 20241213.3
  • Date Produced: December 13, 2024 9:53:43 AM UTC
  • Commit: 2ac96a133cb31a76e48f6827d7b2cef9b9e5d227
  • Branch: refs/heads/vs17.13

@dotnet-maestro
Update dependencies from https://github.com/dotnet/msbuild build 2024…
9b72909 
…1210.7

Microsoft.SourceBuild.Intermediate.msbuild , Microsoft.Build , Microsoft.Build.Localization
 From Version 17.13.0-preview-24569-04 -> To Version 17.13.0-preview-24610-07
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Dec 10, 2024
This was referenced Dec 11, 2024
Open
Open
@dotnet-maestro
Update dependencies from https://github.com/dotnet/msbuild build 2024…
d2c1f9e 
…1211.1

Microsoft.SourceBuild.Intermediate.msbuild , Microsoft.Build , Microsoft.Build.Localization
 From Version 17.13.0-preview-24569-04 -> To Version 17.13.0-preview-24611-01
@build-analysis build-analysis bot mentioned this pull request Dec 11, 2024
Open
@v-wuzhai
Copy link
Member

/azp run dotnet-sdk-public-ci,sdk-source-build,sdk-unified-build

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dotnet-maestro
Update dependencies from https://github.com/dotnet/msbuild build 2024…
eafb79d 
…1212.2

Microsoft.SourceBuild.Intermediate.msbuild , Microsoft.Build , Microsoft.Build.Localization
 From Version 17.13.0-preview-24569-04 -> To Version 17.13.0-preview-24612-02
This was referenced Dec 12, 2024
Open
Open
@dsplaisted
Copy link
Member

@dotnet/kitten Could you take a look at these failures?

Microsoft.NET.Build.Tests.GivenThatWeWantMSBuildToRespectCustomCulture.Microsoft.NET.Build.Tests.GivenThatWeWantMSBuildToRespectCustomCulture.SupportRespectAlreadyAssignedItemCulture_IsNotSupported_BuildShouldFail

Expected command to fail but it did not.
File Name: /datadisks/disk1/work/A6CA09BC/p/d/dotnet
Arguments: msbuild /t:Build /datadisks/disk1/work/A6CA09BC/w/C1790A1E/e/testExecutionDirectory/SupportRespec---5114864F/MSBuildCultureResourceGeneration.csproj /restore
Exit Code: 0
StdOut:
MSBuild version 17.13.0-preview-24612-02+41868360b for .NET
Determining projects to restore...
/datadisks/disk1/work/A6CA09BC/p/d/sdk/9.0.200-ci/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.EolTargetFrameworks.targets(32,5): warning NETSDK1138: The target framework 'net7.0' is out of support and will not receive security updates in the future. Please refer to https://aka.ms/dotnet-core-support for more information about the support policy. [/datadisks/disk1/work/A6CA09BC/w/C1790A1E/e/testExecutionDirectory/SupportRespec---5114864F/MSBuildCultureResourceGeneration.csproj]
/datadisks/disk1/work/A6CA09BC/p/d/sdk/9.0.200-ci/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.EolTargetFrameworks.targets(32,5): warning NETSDK1138: The target framework 'net7.0' is out of support and will not receive security updates in the future. Please refer to https://aka.ms/dotnet-core-support for more information about the support policy. [/datadisks/disk1/work/A6CA09BC/w/C1790A1E/e/testExecutionDirectory/SupportRespec---5114864F/MSBuildCultureResourceGeneration.csproj]
Restored /datadisks/disk1/work/A6CA09BC/w/C1790A1E/e/testExecutionDirectory/SupportRespec---5114864F/MSBuildCultureResourceGeneration.csproj (in 2.4 sec).
/datadisks/disk1/work/A6CA09BC/p/d/sdk/9.0.200-ci/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.EolTargetFrameworks.targets(32,5): warning NETSDK1138: The target framework 'net7.0' is out of support and will not receive security updates in the future. Please refer to https://aka.ms/dotnet-core-support for more information about the support policy. [/datadisks/disk1/work/A6CA09BC/w/C1790A1E/e/testExecutionDirectory/SupportRespec---5114864F/MSBuildCultureResourceGeneration.csproj]
/datadisks/disk1/work/A6CA09BC/p/d/sdk/9.0.200-ci/Microsoft.Common.CurrentVersion.targets(3291,5): warning MSB3002: Explicitly set culture "test-1" for item "Resources.test-1.resx" was overwritten with inferred culture "", because 'RespectAlreadyAssignedItemCulture' property was not set. [/datadisks/disk1/work/A6CA09BC/w/C1790A1E/e/testExecutionDirectory/SupportRespec---5114864F/MSBuildCultureResourceGeneration.csproj]
/datadisks/disk1/work/A6CA09BC/p/d/sdk/9.0.200-ci/Microsoft.Common.CurrentVersion.targets(3291,5): warning MSB3002: Explicitly set culture "test-2" for item "Resources.test-2.resx" was overwritten with inferred culture "", because 'RespectAlreadyAssignedItemCulture' property was not set. [/datadisks/disk1/work/A6CA09BC/w/C1790A1E/e/testExecutionDirectory/SupportRespec---5114864F/MSBuildCultureResourceGeneration.csproj]
MSBuildCultureResourceGeneration -> /datadisks/disk1/work/A6CA09BC/w/C1790A1E/e/testExecutionDirectory/SupportRespec---5114864F/bin/Debug/net7.0/MSBuildCultureResourceGeneration.dll

@rainersigwald
Copy link
Member

@JanKrivanek looks like the culture stuff is cranky here too?

@dotnet-maestro
Update dependencies from https://github.com/dotnet/msbuild build 2024…
c92064f 
…1213.3

Microsoft.SourceBuild.Intermediate.msbuild , Microsoft.Build , Microsoft.Build.Localization
 From Version 17.13.0-preview-24569-04 -> To Version 17.13.1-preview-24613-03
@dkurepa dkurepa mentioned this pull request Dec 18, 2024
Open
@dsplaisted
Copy link
Member

Ping @JanKrivanek @dotnet/kitten to look at MSBuild resource culture failures

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@v-wuzhai @dsplaisted @rainersigwald