Write import map to html files #46233
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,81 @@ | ||
| <!-- | ||
| *********************************************************************************************** | ||
| Microsoft.NET.Sdk.StaticWebAssets.targets | ||
|
|
||
| WARNING: DO NOT MODIFY this file unless you are knowledgeable about MSBuild and have | ||
| created a backup copy. Incorrect changes to this file will make it | ||
| impossible to load or build your projects from the command-line or the IDE. | ||
|
|
||
| Copyright (c) .NET Foundation. All rights reserved. | ||
| *********************************************************************************************** | ||
| --> | ||
|
|
||
| <Project ToolsVersion="14.0"> | ||
|
|
||
| <UsingTask TaskName="Microsoft.AspNetCore.StaticWebAssets.Tasks.WriteImportMapToHtml" AssemblyFile="$(StaticWebAssetsSdkBuildTasksAssembly)" /> | ||
|
|
||
| <PropertyGroup> | ||
| <ResolveBuildRelatedStaticWebAssetsDependsOn> | ||
| $(ResolveStaticWebAssetsInputsDependsOn); | ||
| _UpdateHtmlFiles; | ||
| </ResolveBuildRelatedStaticWebAssetsDependsOn> | ||
| <ResolveCompressedFilesDependsOn> | ||
| $(ResolveCompressedFilesDependsOn); | ||
| _UpdateHtmlFiles | ||
| </ResolveCompressedFilesDependsOn> | ||
| </PropertyGroup> | ||
| <ItemGroup> | ||
| <StaticWebAssetFingerprintPattern Include="Js" Pattern="*.js" Expression="#[.{fingerprint}]!" /> | ||
maraf marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| <StaticWebAssetFingerprintPattern Include="Css" Pattern="*.css" Expression="#[.{fingerprint}]!" /> | ||
maraf marked this conversation as resolved.
Show resolved
Hide resolved
maraf marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| </ItemGroup> | ||
|
|
||
| <Target Name="_UpdateHtmlFiles"> | ||
| <PropertyGroup> | ||
| <_WasmBuildImportMapHtmlPath>$([MSBuild]::NormalizeDirectory($(IntermediateOutputPath), 'importmaphtml', 'build'))</_WasmBuildImportMapHtmlPath> | ||
maraf marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| </PropertyGroup> | ||
|
|
||
| <MakeDir Directories="$(_WasmBuildImportMapHtmlPath)"/> | ||
|
|
||
| <!-- Find HTML swa --> | ||
| <ItemGroup> | ||
| <_HtmlStaticWebAssets Include="@(StaticWebAsset)" Condition="'%(Extension)' == '.html'" /> | ||
| </ItemGroup> | ||
|
|
||
| <!-- Write import map and fingerprinted assets to html files --> | ||
| <WriteImportMapToHtml | ||
| Source="$(PackageId)" | ||
| ManifestType="Build" | ||
| Assets="@(StaticWebAsset)" | ||
| Endpoints="@(StaticWebAssetEndpoint)" | ||
| HtmlFiles="@(_HtmlStaticWebAssets)" | ||
| OutputPath="$(_WasmBuildImportMapHtmlPath)"> | ||
| <Output TaskParameter="HtmlCandidates" ItemName="_HtmlCandidates" /> | ||
| <Output TaskParameter="HtmlFilesToRemove" ItemName="_HtmlFilesToRemove" /> | ||
| <Output TaskParameter="FileWrites" ItemName="FileWrites" /> | ||
|
There was a problem hiding this comment. Is this friendly to incremental build ? |
||
| </WriteImportMapToHtml> | ||
|
|
||
| <!-- Replace modified HTML swa --> | ||
| <ItemGroup> | ||
| <_HtmlCandidatesNoMetadata | ||
| Include="@(_HtmlCandidates)" | ||
| RemoveMetadata="Integrity;Fingerprint" /> | ||
| <_HtmlCandidatesNoMetadata ContentRoot="$(_WasmBuildImportMapHtmlPath)" /> | ||
| </ItemGroup> | ||
| <DefineStaticWebAssets CandidateAssets="@(_HtmlCandidatesNoMetadata)"> | ||
| <Output TaskParameter="Assets" ItemName="_UpdatedHtmlStaticWebAssets" /> | ||
| </DefineStaticWebAssets> | ||
| <DefineStaticWebAssetEndpoints | ||
| CandidateAssets="@(_UpdatedHtmlStaticWebAssets)" | ||
| ExistingEndpoints="@(StaticWebAssetEndpoint)" | ||
| ContentTypeMappings="@(StaticWebAssetContentTypeMapping)" | ||
| > | ||
| <Output TaskParameter="Endpoints" ItemName="_UpdatedHtmlStaticWebAssetsEndpoint" /> | ||
| </DefineStaticWebAssetEndpoints> | ||
| <ItemGroup> | ||
| <StaticWebAsset Remove="@(_HtmlFilesToRemove)" /> | ||
| <StaticWebAsset Include="@(_UpdatedHtmlStaticWebAssets)" /> | ||
| <StaticWebAssetEndpoint Include="@(_UpdatedHtmlStaticWebAssetsEndpoint)" /> | ||
|
There was a problem hiding this comment. Shouldn't we remove the old endpoints too? |
||
| </ItemGroup> | ||
| </Target> | ||
|
|
||
| </Project> | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: This needs to happen also before the service-worker-manifest gets generated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is that? The html documents are not part of service worker assets manifest, aren't they?