-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unified-build lite pipeline #47317
base: main
Are you sure you want to change the base?
Unified-build lite pipeline #47317
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Overview
This PR introduces a unified-build lite pipeline to optimize VMR validations by running a reduced set of build legs, including additional jobs for building tests in internal builds.
- Added an internal lite build section with separate Linux and Windows test build jobs.
- Updated ci.yml conditions to support a unified-build-lite trigger.
Reviewed Changes
File | Description |
---|---|
eng/pipelines/templates/stages/vmr-build.yml | Adds additional jobs for internal lite test builds. |
src/SourceBuild/content/eng/pipelines/ci.yml | Updates build scope conditions to include unified-build-lite. |
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
I think it would be good to first open an issue to discuss and agree on the desired state. |
Makes sense. I'll mark this as draft, and we can close it if needed. |
|
Thanks @NikolaMilosavljevic |
Validation of vmr changes does not always require running all unified-build legs. Having a
lite
pipeline could help improve throughput, and save build resources. This also enable us to validate legs that build tests, as those are now only enabled in public CI or PR.Some concerns
Duplication of jobs for building tests - we already have them in Validation block right above -
sdk/eng/pipelines/templates/stages/vmr-build.yml
Lines 354 to 387 in d833ffb
Perhaps I should just update that condition to include internal/lite scenario and update the comment.
Not sure if both Linux and Windows jobs for building tests would be required, or just one of them.