Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/9.0.1xx] Update GivenThatWeWantMSBuildToRespectCustomCulture.cs #47565

Merged

Conversation

edvilme
Copy link
Member

@edvilme edvilme commented Mar 13, 2025

Manual backport of #47549

Fixes failing SupportRespectAlreadyAssignedItemCulture_IsNotSupported_BuildShouldFail test by consolidating back with the core only test theory.
This is causing all PRs in sdk main to fail because of a machine rollout that updated VS to 17.13.x yesterday.

@Copilot Copilot bot review requested due to automatic review settings March 13, 2025 22:46
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Mar 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR backports a change to resolve failing tests caused by a recent VS update by removing the failing test related to custom culture behavior in MSBuild.

  • Removed the failing test: SupportRespectAlreadyAssignedItemCulture_IsNotSupported_BuildShouldFail to align with the consolidated test theory.
Comments suppressed due to low confidence (1)

test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs:29

  • The removal of the failing test 'SupportRespectAlreadyAssignedItemCulture_IsNotSupported_BuildShouldFail' might reduce coverage for scenarios where a build is expected to fail. Consider adding a comment explaining that this removal is intentional and that related scenarios are either no longer supported or are covered elsewhere.
[Theory]
@edvilme edvilme requested a review from a team March 13, 2025 22:47
@edvilme edvilme enabled auto-merge (squash) March 13, 2025 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants