Skip to content

Conversation

@dotnet-maestro
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Mar 28, 2025

This pull request updates the following dependencies

From https://github.com/dotnet/roslyn-analyzers

…uild 20250328.1

Microsoft.CodeAnalysis.NetAnalyzers , Microsoft.SourceBuild.Intermediate.roslyn-analyzers
 From Version 10.0.0-preview.25177.1 -> To Version 10.0.0-preview.25178.1
@ghost ghost added Area-CodeFlow untriaged Request triage from a team member labels Mar 28, 2025
@dotnet-maestro
Copy link
Contributor Author

Notification for subscribed users from https://github.com/dotnet/roslyn-analyzers:

@dotnet/roslyn-infrastructure-current-swat

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

  • This pull request contains changes from your source repo (https://github.com/dotnet/roslyn-analyzers) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
  • If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
  • For more details, please read the Arcade Darc documentation

@mmitche mmitche enabled auto-merge (squash) March 29, 2025 19:36
…uild 20250330.1

Microsoft.CodeAnalysis.NetAnalyzers , Microsoft.SourceBuild.Intermediate.roslyn-analyzers
 From Version 10.0.0-preview.25177.1 -> To Version 10.0.0-preview.25180.1
@v-wuzhai
Copy link
Contributor

@dotnet/source-build PTAL

…uild 2025033.1

Microsoft.CodeAnalysis.NetAnalyzers , Microsoft.SourceBuild.Intermediate.roslyn-analyzers
 From Version 10.0.0-preview.25177.1 -> To Version 10.0.0-preview.25181.1
@NikolaMilosavljevic
Copy link
Member

@dotnet/source-build PTAL

2 missing PDBs - likely getting reference assemblies included instead of live binaries. Investigating...

Did not find PDBs for the following SDK files:
 /__w/1/vmr/artifacts/obj/extracted-dotnet-sdk/sdk/10.0.100-preview.4.25181.1/DotnetTools/dotnet-watch/10.0.100-preview.4.25181.1/tools/net10.0/any/Microsoft.CodeAnalysis.AnalyzerUtilities.dll
 /__w/1/vmr/artifacts/obj/extracted-dotnet-sdk/sdk/10.0.100-preview.4.25181.1/DotnetTools/dotnet-format/Microsoft.CodeAnalysis.AnalyzerUtilities.dll

@NikolaMilosavljevic
Copy link
Member

Microsoft.CodeAnalysis.AnalyzerUtilities

OK, it's obtaining Microsoft.CodeAnalysis.AnalyzerUtilities package from PSB. It's not built live anymore.

It seems that we need to update roslyn to have this working right. @JoeRobich it appears that this package was removed from roslyn-analyzers repo with dotnet/roslyn-analyzers@63630db

Can we include roslyn update in this PR?

@NikolaMilosavljevic
Copy link
Member

OK, so all analyzers removed from roslyn-analyzers are not missing in source-build, as they have not been moved to roslyn repo yet - dotnet/roslyn#77617

@JoeRobich
Copy link
Member

Can we include roslyn update in this PR?

@NikolaMilosavljevic Working on getting the Roslyn PR in. Roslyn is also having issue with our official build as something is locking files when we are applying optprof. Will keep this issue updated with progress.

@NikolaMilosavljevic
Copy link
Member

This is odd - we are now missing bunch of packages as they have been removed from roslyn-analyzers repo, but not present in roslyn repo yet.

@mmitche @MichaelSimons @jaredpar

@JoeRobich
Copy link
Member

The moved roslyn-analyzers are now merged into Roslyn main.

@JoeRobich
Copy link
Member

@NikolaMilosavljevic We have a Roslyn insertion at #48088.

@NikolaMilosavljevic
Copy link
Member

@NikolaMilosavljevic We have a Roslyn insertion at #48088.

Once that's merged, this PR should be updated to pick up those changes, and the issue should get resolved automatically.

@akoeplinger akoeplinger removed the untriaged Request triage from a team member label Apr 11, 2025
@akoeplinger akoeplinger added the untriaged Request triage from a team member label Apr 11, 2025
@mmitche mmitche merged commit feec389 into main Apr 11, 2025
42 of 43 checks passed
@mmitche mmitche deleted the darc-main-f4ebfadc-c53f-426e-985c-017244289310 branch April 11, 2025 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-CodeFlow untriaged Request triage from a team member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants