Skip to content

[main] Update dependencies from dotnet/roslyn #48583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 19, 2025
Merged

[main] Update dependencies from dotnet/roslyn #48583

merged 2 commits into from
Apr 19, 2025

Conversation

@dotnet-maestro
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Apr 18, 2025 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/roslyn

@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20250…
01492ca 
…418.2

Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.CSharp.CodeStyle , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.PublicApiAnalyzers , Microsoft.CodeAnalysis.Workspaces.Common , Microsoft.CodeAnalysis.Workspaces.MSBuild , Microsoft.Net.Compilers.Toolset , Microsoft.Net.Compilers.Toolset.Framework
 From Version 5.0.0-1.25214.5 -> To Version 4.14.0-1.25218.2
@ghost ghost added Area-CodeFlow untriaged Request triage from a team member labels Apr 18, 2025
@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Apr 18, 2025

Notification for subscribed users from https://github.com/dotnet/roslyn:

@dotnet/roslyn-infrastructure

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

  • This pull request contains changes from your source repo (https://github.com/dotnet/roslyn) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
  • If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
  • For more details, please read the Arcade Darc documentation

@akoeplinger
Copy link
Member

akoeplinger commented Apr 18, 2025

error CS1705: (NETCORE_ENGINEERING_TELEMETRY=Build) Assembly 'Microsoft.CodeAnalysis.Razor.Compiler' with identity 'Microsoft.CodeAnalysis.Razor.Compiler, Version=10.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60' uses 'Microsoft.CodeAnalysis.CSharp, Version=5.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35' which has a higher version than referenced assembly 'Microsoft.CodeAnalysis.CSharp' with identity 'Microsoft.CodeAnalysis.CSharp, Version=4.14.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35'

caused by dotnet/roslyn#78200. I assume this will need a bit of coordination to flow it through all repos

@jaredpar
Copy link
Member

jaredpar commented Apr 18, 2025

caused by dotnet/roslyn#78200. I assume this will need a bit of coordination to flow it through all repos

Yes this is the cause. We're going to likel need the razor flow to go in first.

@jaredpar
Copy link
Member

jaredpar commented Apr 18, 2025

dotnet/razor#11725

Need that change to get merged, that should flow updated razor to sdk, merge that then we can refresh this PR and we should be good.

@akoeplinger
Copy link
Member

akoeplinger commented Apr 18, 2025

I like your optimism 😄

@jaredpar jaredpar force-pushed the darc-main-6e3aec1e-63a1-4eff-a101-e330a21c87f2 branch from f2fa10c to 614eb35 Compare April 18, 2025 23:37
@jaredpar jaredpar requested a review from a team as a code owner April 18, 2025 23:37
@build-analysis build-analysis bot mentioned this pull request Apr 19, 2025
Open
@jaredpar jaredpar force-pushed the darc-main-6e3aec1e-63a1-4eff-a101-e330a21c87f2 branch from 614eb35 to 01492ca Compare April 19, 2025 00:32
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20250…
4a55710 
…418.9

Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.CSharp.CodeStyle , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.PublicApiAnalyzers , Microsoft.CodeAnalysis.Workspaces.Common , Microsoft.CodeAnalysis.Workspaces.MSBuild , Microsoft.Net.Compilers.Toolset , Microsoft.Net.Compilers.Toolset.Framework
 From Version 5.0.0-1.25214.5 -> To Version 5.0.0-1.25218.9
@dotnet-maestro dotnet-maestro bot merged commit 1add7a3 into main Apr 19, 2025
43 checks passed
@dotnet-maestro dotnet-maestro bot deleted the darc-main-6e3aec1e-63a1-4eff-a101-e330a21c87f2 branch April 19, 2025 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jjonescz jjonescz jjonescz approved these changes

Assignees

No one assigned

Labels

Area-CodeFlow untriaged Request triage from a team member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@akoeplinger @jaredpar @jjonescz