Properly consume Version.Details.props #50040
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This got accidentally consumed in an earlier darc PR already but it was not hooked up correctly yet.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the consumption of Version.Details.props by properly importing it at the top of the eng/Versions.props file and removing many hardcoded version properties that will now be managed through the imported file.
- Adds proper import of Version.Details.props with existence check
- Removes numerous hardcoded version properties for dependencies from various repositories (runtime, templating, roslyn, aspnetcore, etc.)
- Maintains only manually updated dependencies and specific toolset versions
baronfel
approved these changes
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This got accidentally consumed in an earlier darc PR already but it was not hooked up correctly yet.