-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Update analyzer redirecting VS extension #50496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update analyzer redirecting VS extension #50496
Conversation
This reverts commit d91fcd6.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the analyzer redirecting VS extension to complete the implementation following up on a previous PR. Key changes include adding an opt-out environment variable, improving the VS extension configuration, and restructuring the analyzer layout.
- Added logging capabilities and opt-out environment variable (
DOTNET_ANALYZER_REDIRECTING
) - Restructured analyzer deployment layout to remove version numbers from directories
- Updated VS extension to be a system component that doesn't appear in installed extensions list
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
File | Description |
---|---|
test/Microsoft.Net.Sdk.AnalyzerRedirecting.Tests/SdkAnalyzerAssemblyRedirectorTests.cs |
Updated tests to use new metadata-based version tracking instead of version directories |
src/Tasks/sdk-tasks/sdk-tasks.InTree.targets |
Added new MSBuild task ProcessRuntimeAnalyzerVersions for version extraction |
src/Tasks/sdk-tasks/ProcessRuntimeAnalyzerVersions.cs |
New task to extract version numbers and create metadata JSON file |
src/Tasks/sdk-tasks/GenerateRuntimeAnalyzersSWR.cs |
Updated layout paths and added metadata.json file inclusion |
src/Microsoft.Net.Sdk.AnalyzerRedirecting/source.extension.vsixmanifest |
Updated to VS 19.0 compatibility and system component configuration |
src/Microsoft.Net.Sdk.AnalyzerRedirecting/SdkAnalyzerAssemblyRedirector.cs |
Added logging, opt-out mechanism, and updated to use metadata-based version lookup |
src/Microsoft.Net.Sdk.AnalyzerRedirecting/Microsoft.Net.Sdk.AnalyzerRedirecting.csproj |
Added System.Text.Json dependency for metadata processing |
src/Layout/VS.Redist.Common.Net.Core.SDK.RuntimeAnalyzers/VS.Redist.Common.Net.Core.SDK.RuntimeAnalyzers.proj |
Updated build process to use new version extraction and VS extension configuration |
documentation/general/analyzer-redirecting.md |
Updated documentation to reflect new metadata-based approach |
src/Microsoft.Net.Sdk.AnalyzerRedirecting/SdkAnalyzerAssemblyRedirector.cs
Show resolved
Hide resolved
@JoeRobich @RikkiGibson @333fred for reviews, thanks Btw, I think I can merge this into |
Follow up on #42861.