Skip to content

Conversation

@NikolaMilosavljevic
Copy link
Member

@NikolaMilosavljevic NikolaMilosavljevic commented Sep 17, 2025

There is no need to build source-build legs in any feature band except 8.0.1xx. We often see issues related to this leg that require unnecessary work - i.e. #50847 (comment)

This will need to be backported to 8.0.3xx.

NOTE - merge only after dotnet/installer#20614 is merged

@MichaelSimons
Copy link
Member

This is going to affect downstream repo consumers like installer which depends on the source build intermediates produced from this leg. The installer legs should be removed first before merging this.

@NikolaMilosavljevic
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@NikolaMilosavljevic
Copy link
Member Author

Installer PR was merged: dotnet/installer#20614

This PR can now be merged, once approved.

@NikolaMilosavljevic
Copy link
Member Author

This is failing some unrelated tests in regular Linux build leg.

@NikolaMilosavljevic
Copy link
Member Author

NikolaMilosavljevic commented Oct 9, 2025

@marcpopMSFT - can we remove Branch Lockdown label now?

We shouldn't merge this until dotnet/installer#20640 flows to 4xx, and a redo of dotnet/installer#20614 is in place in installer's 4xx

@NikolaMilosavljevic
Copy link
Member Author

Unrelated failure that seems transient.

@NikolaMilosavljevic NikolaMilosavljevic merged commit 91390df into dotnet:release/8.0.4xx Oct 14, 2025
16 of 18 checks passed
@NikolaMilosavljevic
Copy link
Member Author

/backport to release/8.0.3xx

@github-actions
Copy link
Contributor

Started backporting to release/8.0.3xx: https://github.com/dotnet/sdk/actions/runs/18511858202

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants