Skip to content

Conversation

@baronfel
Copy link
Member

Fixes #50755

.NET Tools don't expose APIs and so should not participate in API baseline validation.

@baronfel baronfel requested a review from a team September 18, 2025 15:47
@ViktorHofer
Copy link
Member

@baronfel EnablePackageValidation=true is an opt-in experience so it doesn't run by default. Is the intention of this change to override a user setting? If so, a refinement of this condition here might make more sense:

Condition="'$(EnablePackageValidation)' == 'true' and '$(IsPackable)' == 'true'">

@baronfel
Copy link
Member Author

baronfel commented Sep 18, 2025

yeah, we do intend to override a user setting - it's never correct for Tools to do package validation IMO. Architecturally, I want to keep the validation targets ignorant of tools - they are doing the correct thing by providing knobs, it's up to the specific feature/experiences to use those knobs to deliver the desired experience.

@baronfel baronfel enabled auto-merge (squash) September 18, 2025 23:08
@baronfel baronfel closed this Sep 19, 2025
auto-merge was automatically disabled September 19, 2025 20:05

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants