Skip to content

Fix process cleanup timeout causing port binding errors in no-hot-reload mode #51632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tmat merged 1 commit into from
Dec 4, 2025
Merged

Fix process cleanup timeout causing port binding errors in no-hot-reload mode #51632

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/BuiltInTools/Watch/Context/EnvironmentOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,8 @@ internal sealed record EnvironmentOptions(
);

public TimeSpan GetProcessCleanupTimeout(bool isHotReloadEnabled)
// If Hot Reload mode is disabled the process is restarted on every file change.
// Waiting for graceful termination would slow down the turn around.
=> ProcessCleanupTimeout ?? (isHotReloadEnabled ? TimeSpan.FromSeconds(5) : TimeSpan.FromSeconds(0));
// Allow sufficient time for the process to exit gracefully and release resources (e.g., network ports).
=> ProcessCleanupTimeout ?? TimeSpan.FromSeconds(5);

private int _uniqueLogId;

Expand Down