-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[automated] Merge branch 'release/10.0.2xx' => 'main' #52149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@jjonescz May you PTAL at this merge conflict? Do you intend to move all of the .NET run command code into this separate function style? |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
No, just pieces that need to be shared with dotnet-watch or roslyn. If you are talking about the refactoring done in #52030. |
|
The conflicts here seem to be from the combination of these two PRs:
Which I'm seeing for the first time. I have resolved the conflicts but @jonathanpeppers @baronfel @tmat should probably also take a look. |
|
There should be sufficient unit/integration tests for Do you have a list of the conflicting file names? I didn't see it on the commit above. |
|
Ah, sorry, don't have it anymore, it was RunCommand.cs, RunApiCommand.cs, RunCommandParser.cs IIRC. You can also try merging release/10.0.2xx to main locally to see the exact conflicts (and feel free to re-resolve them and force-push to this PR). |
|
For others reviewing: |
jonathanpeppers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| command.Options.Add(DeviceOption); | ||
| command.Options.Add(ListDevicesOption); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are the new options for dotnet run, looks good.

I detected changes in the release/10.0.2xx branch which have not been merged yet to main. I'm a robot and am configured to help you automatically keep main up to date, so I've opened this PR.
This PR merges commits made on release/10.0.2xx by the following committers:
Instructions for merging from UI
This PR will not be auto-merged. When pull request checks pass, complete this PR by creating a merge commit, not a squash or rebase commit.
If this repo does not allow creating merge commits from the GitHub UI, use command line instructions.
Instructions for merging via command line
Run these commands to merge this pull request from the command line.
or if you are using SSH
After PR checks are complete push the branch
Instructions for resolving conflicts
Instructions for updating this pull request
Contributors to this repo have permission update this pull request by pushing to the branch 'merge/release/10.0.2xx-to-main'. This can be done to resolve conflicts or make other changes to this pull request before it is merged.
The provided examples assume that the remote is named 'origin'. If you have a different remote name, please replace 'origin' with the name of your remote.
or if you are using SSH
Contact .NET Core Engineering (dotnet/dnceng) if you have questions or issues.
Also, if this PR was generated incorrectly, help us fix it. See https://github.com/dotnet/arcade/blob/main/.github/workflows/scripts/inter-branch-merge.ps1.