Import common targets if LanguageTargets property isn't set. #539
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow restore to succeed. Fixes #448. Fixes #373
Rather than generating an error (as specified in #448), this PR imports the common targets if the
LanguageTargets
property isn't set. This means that restore can succeed even if the language targets aren't otherwise set, which means that F# or another language could be provided solely as a NuGet package instead of an MSBuild SDK.@enricosada How does this look to you? Once it is possible to have third party SDKs (see dotnet/msbuild#1493), you may still prefer to use an SDK for F# over a NuGet package. It would make the project files more succinct and might avoid the project showing up differently in solution explorer when you create or open a project before the restore completes.