Microbuild Additions #7
Conversation
| @@ -1,5 +1,6 @@ | |||
| { | |||
| "dependencies": { | |||
| "MicroBuild.Core": "0.2.0", | |||
There was a problem hiding this comment.
This makes me nervous that our official product assembly needs to depend on MicroBuild. Is this how other projects work in Roslyn?
There was a problem hiding this comment.
I believe so. See https://github.com/dotnet/roslyn-project-system/blob/master/src/Dependencies/Toolset/project.json for an example.
There was a problem hiding this comment.
But isn't the difference that there is just a random "toolset" project that depends on MicroBuild.Core, and here we are making our actual shipping assembly's project depend on MicroBuild.Core? The equivalent in my mind would be if https://github.com/dotnet/roslyn-project-system/tree/master/src/Microsoft.VisualStudio.ProjectSystem.Managed had a direct dependency on MicroBuild.Core.
|
This is only part of the change. We still need more Microbuild related things to get this project built in Microbuild. This Commit in Roslyn-PS is good starting point. |
|
@dotnet-bot test Windows Debug |
|
@dotnet-bot test Windows Debug |
|
@dotnet-bot retest Windows Release |
| <?xml version="1.0" encoding="utf-8"?> | ||
| <Project ToolsVersion="14.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | ||
| <Choose> | ||
| <When Condition="'$(ProjectLanguage)' == 'VB'"> |
There was a problem hiding this comment.
Not sure we need this VB stuff, so we?
There was a problem hiding this comment.
I doubt we need it either, I've been copying from the Roslyn-project-system, and committed and pushed last night before I left. Still some more cleanup to do.
|
|
||
| <VersionPrefix Condition="'$(VersionPrefix)' == ''">1.0.0</VersionPrefix> | ||
| <!-- When running on Microbuild, this is set to "ymmdd.n". --> | ||
| <VersionSuffix Condition="'$(VersionSuffix)' == ''">$(BuildVersion)</VersionSuffix> |
There was a problem hiding this comment.
One thing to be careful about here is that nuget versions can't have a number as the first character after the -. So you always need some sort of alpha letter to start the prerelease ($(VersionSuffix)) part. Typically things like alpha, beta, preview, etc. These prerelease prefixes are usually checked into the repo, like the major, minor and patch numbers are.
|
Because microbuild relies on the desktop version of msbuild, and we're running with the xplat version, we're not going to be able to use it directly. I'll be looking into how roslyn is doing signing, since they have to deal with this issue as well. I'll submit a new PR when I have something ready to review. |
Adding build scripts
3 participants
This adds the nuget dependency for building on MicroBuild, as well as installing our dotnet cli to the auto-cleaned folder when running on MicroBuild. Tagging @eerhardt for review. @basoundr, is there anything you can think of that we're missing for building?