Correct creation of the CryptographyClient in the KeyVaultService. #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corrects the implementation of the creation of the CryptographyClient. The
KeyClientthat was created used theKeyIdinstead of the url of the keyvault here:KeyClient keyClient = new(certificateWithPolicy.KeyId, _tokenCredential);. And that was then used to create aCryptographyClientwith an incorrect url.I have fixed this by creating the
CryptographyClientwithout using theKeyClientbecause we already get this information when the public key is retrieved. I have also removed the_taskfield to make it possible to pass thecancellationTokento theGetCertificateAsynccall.