add microsoft.codeanalysis 4.4.0 #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleksandr-didyk
requested review from
MichaelSimons and
mthalman
as code owners
mthalman
reviewed
Apr 12, 2023
eng/Build.props
Outdated
Comment on lines
155
to
160
| <DependencyPackageProjects Include="$(RepoRoot)src\referencePackages\src\**\System.Composition.AttributedModel.6.0.0.csproj" /> | ||
| <DependencyPackageProjects Include="$(RepoRoot)src\referencePackages\src\**\System.Composition.Runtime.6.0.0.csproj" /> | ||
| <DependencyPackageProjects Include="$(RepoRoot)src\referencePackages\src\**\System.Composition.Hosting.6.0.0.csproj" /> | ||
| <DependencyPackageProjects Include="$(RepoRoot)src\referencePackages\src\**\System.Composition.TypedParts.6.0.0.csproj" /> | ||
| <DependencyPackageProjects Include="$(RepoRoot)src\referencePackages\src\**\System.Composition.Convetion.6.0.0.csproj" /> | ||
| <DependencyPackageProjects Include="$(RepoRoot)src\textOnlyPackages\src\**\System.Composition.6.0.0.csproj" /> |
There was a problem hiding this comment.
I don't see any of these projects included in the sources.
There was a problem hiding this comment.
It as added as part of Mats PR for SDK's SBRP, but I missed them being in this file. Thanks for noticing, will remove
mthalman
approved these changes
Apr 13, 2023
MichaelSimons
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of dotnet/runtime#81468