Pin targeting pack version for net8.0 #876
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
This does not seem to fix the issue and I'm not sure why. Here's my test build (internal link). It's still showing up as a prebuilt in the stage 2 build. @MichaelSimons - Do you have any ideas on what's going on? |
Member
|
IIRC, this change will only affects SBRP. Do you know what repo is bring in 8.0.1? Building locally an looking at the repo level prebuilt reports is a way to narrow it down. We don't capture these reports in CI artifacts. |
Member
Author
|
This does resolve the SBRP issue. There's another similar issue to fix in SBE. |
mthalman
requested review from
MichaelSimons and
oleksandr-didyk
as code owners
MichaelSimons
approved these changes
Jan 25, 2024
ericstj
pushed a commit
to ericstj/source-build-reference-packages
that referenced
this pull request
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/source-build#4037
I'm running a test build now to verify this does indeed fix the issue.