- 
                Notifications
    
You must be signed in to change notification settings  - Fork 68
 
Add MSBuild 17.8.3 + dependencies #885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    ... necessary for dotnet/runtime#98006
              
                    mthalman
  
              
              reviewed
              
                  
                    Feb 6, 2024 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there's a build error.
              
                    oleksandr-didyk
  
              
              approved these changes
              
                  
                    Feb 7, 2024 
                  
              
              
            
            
| 
           Looks like we need a couple more MSBuild packages for this to be complete: dotnet/runtime#98006 (comment)  | 
    
    
  ViktorHofer 
      added a commit
      that referenced
      this pull request
    
      Feb 8, 2024 
    
    
      
  
    
      
    
  
Required for dotnet/runtime#98006 Follow-up on #885
    
  MichaelSimons 
      pushed a commit
      that referenced
      this pull request
    
      Feb 8, 2024 
    
    
      
  
    
      
    
  
…8.3 (#886) * Add Microsoft.Build.Tasks.Core and Microsoft.Build.Utilities.Core 17.8.3 Required for dotnet/runtime#98006 Follow-up on #885 * Update unrelated files * Manual change because of attribute filtering by GenAPI * Remove dependency from nuspec as well
      
        
      
      
  
    4 tasks
  
    
  ericstj 
      pushed a commit
        to ericstj/source-build-reference-packages
      that referenced
      this pull request
    
      Apr 8, 2024 
    
    
      
  
    
      
    
  
* Add MSBuild 17.8.3 + dependencies ... necessary for dotnet/runtime#98006 * Add manual pragma warning disable as in dotnet/runtime
    
  ericstj 
      pushed a commit
        to ericstj/source-build-reference-packages
      that referenced
      this pull request
    
      Apr 8, 2024 
    
    
      
  
    
      
    
  
…8.3 (dotnet#886) * Add Microsoft.Build.Tasks.Core and Microsoft.Build.Utilities.Core 17.8.3 Required for dotnet/runtime#98006 Follow-up on dotnet#885 * Update unrelated files * Manual change because of attribute filtering by GenAPI * Remove dependency from nuspec as well
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
... necessary for dotnet/runtime#98006