Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jbevain/cecil (Mono.Cecil official repo) to source-build #1537

Closed
dagood opened this issue Mar 23, 2020 · 6 comments
Closed

Add jbevain/cecil (Mono.Cecil official repo) to source-build #1537

dagood opened this issue Mar 23, 2020 · 6 comments
Assignees
Labels
area-additional-repos Adding additional contributing repos
Milestone

Comments

@dagood
Copy link
Member

dagood commented Mar 23, 2020

Right now, we build mono/linker, which has a mono/cecil submodule. In 5.0, the mono/cecil submodule won't be used anymore, and instead the official Mono.Cecil package built by jbevain/cecil and published to the NuGet gallery will be adopted. This means we'll need to add this repository to avoid the prebuilt.

https://github.com/jbevain/cecil/

@dagood dagood added the area-additional-repos Adding additional contributing repos label Mar 23, 2020
@dagood dagood added this to the 5.0 milestone Mar 23, 2020
@omajid omajid self-assigned this Sep 23, 2020
@omajid
Copy link
Member

omajid commented Sep 23, 2020

I am going to take a shot at it, but it will be slow as I am learning things.

@omajid
Copy link
Member

omajid commented Sep 23, 2020

Can't even figure out how to build it 😢

I filed jbevain/cecil#693 to get some help

@marek-safar
Copy link

There was a change in the strategy for .net5 and mono/cecil submodule is still used instead of Mono.Cecil NuGet.

@omajid
Copy link
Member

omajid commented Sep 24, 2020

Thanks, @marek-safar

@dagood Sounds like we should close this issue, then?

@dagood
Copy link
Member Author

dagood commented Sep 24, 2020

Thanks for the update. @marek-safar, do you know when dotnet/linker#1477 will end up in a release? rc2, GA?

That PR looks like it'll make our prebuilt disappear once that happens, which is good.

@marek-safar
Copy link

@dagood dotnet/linker#1477 should be included in rc2 but last time I checked the update was sitting in dotnet/sdk PRs queue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-additional-repos Adding additional contributing repos
Projects
None yet
Development

No branches or pull requests

4 participants