Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/5.0] Remove Mono.Cecil/0.11.2 prebuilt #1804

Closed
dagood opened this issue Oct 14, 2020 · 2 comments
Closed

[release/5.0] Remove Mono.Cecil/0.11.2 prebuilt #1804

dagood opened this issue Oct 14, 2020 · 2 comments
Labels
area-prebuilts Reducing the number of prebuilt packages in the tarball

Comments

@dagood
Copy link
Member

dagood commented Oct 14, 2020 •
edited
Loading

We were going to add the Cecil repo to source-build to produce the Mono.Cecil package (#1537), but plans changed for mono/linker, and linker will go back to compiling its submodule of Mono.Cecil.

This PR makes mono/linker use the submodule again: dotnet/linker#1477.

We should automatically get that PR in 5.0-rc2. However, to ship 5.0-rc1 without prebuilts we could port that PR as a patch to this repo.
@dagood dagood added the area-prebuilts Reducing the number of prebuilt packages in the tarball label Oct 14, 2020
@dagood dagood mentioned this issue Oct 14, 2020
Closed
@omajid omajid assigned omajid and unassigned omajid Oct 27, 2020
@dagood
Copy link
Member Author

dagood commented Nov 3, 2020

I expect this to be fixed by the GA PR, #1845. If not, we need to take a closer look.

@dagood
Copy link
Member Author

dagood commented Nov 23, 2020

This has been gone for a while, after the GA PR.

@dagood dagood closed this as completed Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-prebuilts Reducing the number of prebuilt packages in the tarball
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@omajid @dseefeld @dagood