Skip to content

Fix dependence on ambient default agent pool in arcade-powered source-build AzDO templates #1795

@dagood

Description

@dagood

@brettfo encountered an issue in dotnet/fsharp#10243 where the arcade-powered sb template tried to use an old Windows agent to run our Docker containers for source-build, which failed, but the same template usage got a Linux agent and worked in dotnet/source-build-reference-packages.

I think the cause is the default pool here:

sbrp

vs. fsharp:

fsharp

I think the right fix is to always specify a pool here, so we don't depend on the ambient default (from the AzDO pipeline definition in this case, but a stage could also cause this I think):

https://github.com/dotnet/arcade/blob/abf9263d1fe9eb075cb5f9d117c9e36668b99408/eng/common/templates/job/source-build.yml#L38-L41

Something like this:

  ${{ if ne(parameters.platform.container, '') }}:
    container: ${{ parameters.platform.container }}
    pool: ${{ coalesce(parameters.platform.containerHost, parameters.defaultContainerHostPool) }}

Metadata

Metadata

Assignees

Labels

area-infraSource-build infrastructure and reporting

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions