Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Portable build contains prebuilts #1937

Closed
dseefeld opened this issue Dec 3, 2020 · 2 comments
Closed

Portable build contains prebuilts #1937

dseefeld opened this issue Dec 3, 2020 · 2 comments
Assignees
@dagood
Labels
area-build Improvements in source-build's own build process area-prebuilts Reducing the number of prebuilt packages in the tarball

Comments

@dseefeld
Copy link
Contributor

dseefeld commented Dec 3, 2020

The portable build for source-build contains prebuilts when the other builds don't. Here are the prebuilts detected when building portable:

/src/eng/SourceBuild.Tarball.targets(364,5): error : Detected forbidden prebuilts. They must be removed, or explicitly allowed (see target for details): [/src/packages/restored/microsoft.dotnet.arcade.sdk/5.0.0-beta.20426.4/tools/Build.proj]
/src/eng/SourceBuild.Tarball.targets(364,5): error : /tb/tarball_907431/packages/prebuilt/runtime.any.system.collections.4.3.0.nupkg [/src/packages/restored/microsoft.dotnet.arcade.sdk/5.0.0-beta.20426.4/tools/Build.proj]
/src/eng/SourceBuild.Tarball.targets(364,5): error : /tb/tarball_907431/packages/prebuilt/runtime.any.system.diagnostics.tools.4.3.0.nupkg [/src/packages/restored/microsoft.dotnet.arcade.sdk/5.0.0-beta.20426.4/tools/Build.proj]
/src/eng/SourceBuild.Tarball.targets(364,5): error : /tb/tarball_907431/packages/prebuilt/runtime.any.system.diagnostics.tracing.4.3.0.nupkg [/src/packages/restored/microsoft.dotnet.arcade.sdk/5.0.0-beta.20426.4/tools/Build.proj]
/src/eng/SourceBuild.Tarball.targets(364,5): error : /tb/tarball_907431/packages/prebuilt/runtime.any.system.globalization.4.3.0.nupkg [/src/packages/restored/microsoft.dotnet.arcade.sdk/5.0.0-beta.20426.4/tools/Build.proj]
/src/eng/SourceBuild.Tarball.targets(364,5): error : /tb/tarball_907431/packages/prebuilt/runtime.any.system.globalization.calendars.4.3.0.nupkg [/src/packages/restored/microsoft.dotnet.arcade.sdk/5.0.0-beta.20426.4/tools/Build.proj]
/src/eng/SourceBuild.Tarball.targets(364,5): error : /tb/tarball_907431/packages/prebuilt/runtime.any.system.io.4.3.0.nupkg [/src/packages/restored/microsoft.dotnet.arcade.sdk/5.0.0-beta.20426.4/tools/Build.proj]
/src/eng/SourceBuild.Tarball.targets(364,5): error : /tb/tarball_907431/packages/prebuilt/runtime.any.system.reflection.4.3.0.nupkg [/src/packages/restored/microsoft.dotnet.arcade.sdk/5.0.0-beta.20426.4/tools/Build.proj]
/src/eng/SourceBuild.Tarball.targets(364,5): error : /tb/tarball_907431/packages/prebuilt/runtime.any.system.reflection.extensions.4.3.0.nupkg [/src/packages/restored/microsoft.dotnet.arcade.sdk/5.0.0-beta.20426.4/tools/Build.proj]
/src/eng/SourceBuild.Tarball.targets(364,5): error : /tb/tarball_907431/packages/prebuilt/runtime.any.system.reflection.primitives.4.3.0.nupkg [/src/packages/restored/microsoft.dotnet.arcade.sdk/5.0.0-beta.20426.4/tools/Build.proj]
/src/eng/SourceBuild.Tarball.targets(364,5): error : /tb/tarball_907431/packages/prebuilt/runtime.any.system.resources.resourcemanager.4.3.0.nupkg [/src/packages/restored/microsoft.dotnet.arcade.sdk/5.0.0-beta.20426.4/tools/Build.proj]
/src/eng/SourceBuild.Tarball.targets(364,5): error : /tb/tarball_907431/packages/prebuilt/runtime.any.system.runtime.4.3.0.nupkg [/src/packages/restored/microsoft.dotnet.arcade.sdk/5.0.0-beta.20426.4/tools/Build.proj]
/src/eng/SourceBuild.Tarball.targets(364,5): error : /tb/tarball_907431/packages/prebuilt/runtime.any.system.runtime.handles.4.3.0.nupkg [/src/packages/restored/microsoft.dotnet.arcade.sdk/5.0.0-beta.20426.4/tools/Build.proj]
/src/eng/SourceBuild.Tarball.targets(364,5): error : /tb/tarball_907431/packages/prebuilt/runtime.any.system.runtime.interopservices.4.3.0.nupkg [/src/packages/restored/microsoft.dotnet.arcade.sdk/5.0.0-beta.20426.4/tools/Build.proj]
/src/eng/SourceBuild.Tarball.targets(364,5): error : /tb/tarball_907431/packages/prebuilt/runtime.any.system.text.encoding.4.3.0.nupkg [/src/packages/restored/microsoft.dotnet.arcade.sdk/5.0.0-beta.20426.4/tools/Build.proj]
/src/eng/SourceBuild.Tarball.targets(364,5): error : /tb/tarball_907431/packages/prebuilt/runtime.any.system.text.encoding.extensions.4.3.0.nupkg [/src/packages/restored/microsoft.dotnet.arcade.sdk/5.0.0-beta.20426.4/tools/Build.proj]
/src/eng/SourceBuild.Tarball.targets(364,5): error : /tb/tarball_907431/packages/prebuilt/runtime.any.system.threading.tasks.4.3.0.nupkg [/src/packages/restored/microsoft.dotnet.arcade.sdk/5.0.0-beta.20426.4/tools/Build.proj]
/src/eng/SourceBuild.Tarball.targets(364,5): error : /tb/tarball_907431/packages/prebuilt/runtime.any.system.threading.timer.4.3.0.nupkg [/src/packages/restored/microsoft.dotnet.arcade.sdk/5.0.0-beta.20426.4/tools/Build.proj]
/src/eng/SourceBuild.Tarball.targets(364,5): error : /tb/tarball_907431/packages/prebuilt/runtime.unix.microsoft.win32.primitives.4.3.0.nupkg [/src/packages/restored/microsoft.dotnet.arcade.sdk/5.0.0-beta.20426.4/tools/Build.proj]
/src/eng/SourceBuild.Tarball.targets(364,5): error : /tb/tarball_907431/packages/prebuilt/runtime.unix.system.console.4.3.0.nupkg [/src/packages/restored/microsoft.dotnet.arcade.sdk/5.0.0-beta.20426.4/tools/Build.proj]
/src/eng/SourceBuild.Tarball.targets(364,5): error : /tb/tarball_907431/packages/prebuilt/runtime.unix.system.diagnostics.debug.4.3.0.nupkg [/src/packages/restored/microsoft.dotnet.arcade.sdk/5.0.0-beta.20426.4/tools/Build.proj]
/src/eng/SourceBuild.Tarball.targets(364,5): error : /tb/tarball_907431/packages/prebuilt/runtime.unix.system.io.filesystem.4.3.0.nupkg [/src/packages/restored/microsoft.dotnet.arcade.sdk/5.0.0-beta.20426.4/tools/Build.proj]
/src/eng/SourceBuild.Tarball.targets(364,5): error : /tb/tarball_907431/packages/prebuilt/runtime.unix.system.net.primitives.4.3.0.nupkg [/src/packages/restored/microsoft.dotnet.arcade.sdk/5.0.0-beta.20426.4/tools/Build.proj]
/src/eng/SourceBuild.Tarball.targets(364,5): error : /tb/tarball_907431/packages/prebuilt/runtime.unix.system.net.sockets.4.3.0.nupkg [/src/packages/restored/microsoft.dotnet.arcade.sdk/5.0.0-beta.20426.4/tools/Build.proj]
/src/eng/SourceBuild.Tarball.targets(364,5): error : /tb/tarball_907431/packages/prebuilt/runtime.unix.system.private.uri.4.3.0.nupkg [/src/packages/restored/microsoft.dotnet.arcade.sdk/5.0.0-beta.20426.4/tools/Build.proj]
/src/eng/SourceBuild.Tarball.targets(364,5): error : /tb/tarball_907431/packages/prebuilt/runtime.unix.system.runtime.extensions.4.3.0.nupkg [/src/packages/restored/microsoft.dotnet.arcade.sdk/5.0.0-beta.20426.4/tools/Build.proj]
/src/eng/SourceBuild.Tarball.targets(364,5): error : /tb/tarball_907431/packages/prebuilt/system.private.uri.4.3.0.nupkg [/src/packages/restored/microsoft.dotnet.arcade.sdk/5.0.0-beta.20426.4/tools/Build.proj]
@dseefeld dseefeld added area-build Improvements in source-build's own build process area-prebuilts Reducing the number of prebuilt packages in the tarball labels Dec 3, 2020
@dseefeld dseefeld mentioned this issue Dec 3, 2020
Merged
@dagood dagood self-assigned this Dec 7, 2020
@dagood dagood mentioned this issue Dec 8, 2020
Merged
@dagood
Copy link
Member

dagood commented Dec 8, 2020

Poking at a handful of these in the annotated usage file, these seem to all come from building the Crossgen2 pack in the portable build, which we shouldn't build in source-build and need to disable: #1568.

@dagood dagood mentioned this issue Dec 8, 2020
Merged
@dagood
Copy link
Member

dagood commented Dec 8, 2020

Fixed by #1945

@dagood dagood closed this as completed Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dagood dagood

Labels
area-build Improvements in source-build's own build process area-prebuilts Reducing the number of prebuilt packages in the tarball
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dseefeld @dagood