Fix coreclr binlog: corrupted patch #1944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crummel
approved these changes
Dec 8, 2020
|
It looks like with 26c298f#diff-c72afe4ad8f6530dfdc0d7bb0a852e671bd0e57d4bf2dda5af448d9a1e38aebe, the patch was changed without updating the line count. Within the commits of the PR that was squashed to make that commit, I see this tighter diff which only adds one line and makes the patch wrong: d0caaea#diff-c72afe4ad8f6530dfdc0d7bb0a852e671bd0e57d4bf2dda5af448d9a1e38aebe. Maybe the patch text was manually modified without updating the rest of the patch properly? Seems like the simplest answer to me. |
|
Merging past #1937. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recreate the patch adding the dotnet/runtime
build-source-build.sh: it wasn't adding the last line. This ends up overwriting the coreclr binlog in the portable build.Fixes #1943.