Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible regression in shell completion with .NET 6.0 #2012

Open
omajid opened this issue Feb 1, 2021 · 3 comments
Open

Possible regression in shell completion with .NET 6.0 #2012

omajid opened this issue Feb 1, 2021 · 3 comments
Labels
area-product-experience Improvements in the end-user's product experience

Comments

@omajid
Copy link
Member

omajid commented Feb 1, 2021

The CLI/SDK is switching to System.CommandLine: dotnet/core#5853 (comment)

For shell completion to work, this will require installing the dotnet-suggest tool: https://github.com/dotnet/command-line-api/blob/main/docs/dotnet-suggest.md

How does this work with Linux distributions? Can shell completion work without this glboal tool? Can we build dotnet-suggest from source? If we can't, what's the alternative option?

@dagood
Copy link
Member

dagood commented Feb 1, 2021

The csproj itself doesn't look bad at first glance: https://github.com/dotnet/command-line-api/blob/main/src/System.CommandLine.Suggest/dotnet-suggest.csproj. But we do have this patch to remove it, citing prebuilts: https://github.com/dotnet/source-build/blob/release/5.0/patches/command-line-api/0001-Exclude-dotnet-suggest-from-source-build.patch

(I filed dotnet/command-line-api#1183 to ask about the System.CommandLine.Suggest/dotnet-suggest naming mismatch.)

@dagood dagood added the area-product-experience Improvements in the end-user's product experience label Feb 1, 2021
@omajid
Copy link
Member Author

omajid commented Feb 3, 2021

Thinking out loud: once we can build dotnet-suggest.csproj, what's the next step? This is supposed to be a global tool; is there some way to actually install this site-wide?

@dagood
Copy link
Member

dagood commented Feb 3, 2021

I imagined it would fit into https://github.com/dotnet/installer/blob/e8658412c76bac170e482935ebf9316fcf5d7f9e/src/redist/targets/BundledDotnetTools.targets, but I'm not really familiar with how that infra works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-product-experience Improvements in the end-user's product experience
Projects
Status: Backlog
Development

No branches or pull requests

4 participants