Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In 6.0, bring forward 5.0 patch that removes MSBuild, Roslyn dependency on Microsoft.VisualStudio.Setup.Configuration.Interop non-OSS prebuilt #2542

Closed
dagood opened this issue Oct 20, 2021 · 0 comments
Closed

In 6.0, bring forward 5.0 patch that removes MSBuild, Roslyn dependency on Microsoft.VisualStudio.Setup.Configuration.Interop non-OSS prebuilt #2542

dagood opened this issue Oct 20, 2021 · 0 comments
Assignees
@dseefeld
Labels
area-prebuilts Reducing the number of prebuilt packages in the tarball
Milestone
6.0

Comments

@dagood
Copy link
Member

dagood commented Oct 20, 2021

https://github.com/dotnet/source-build/blob/release/5.0/patches/msbuild/0006-Do-not-depend-on-Visual-Studio-in-source-build.patch

(net472 dotnet/msbuild source-build enabled by https://github.com/dotnet/source-build/blob/release/5.0/patches/msbuild/0005-Re-enable-full-fx-builds-in-source-build.patch in 5.0)
@dagood dagood added the area-prebuilts Reducing the number of prebuilt packages in the tarball label Oct 20, 2021
@dagood dagood mentioned this issue Oct 20, 2021
Merged
@dagood dagood added this to the 6.0 milestone Oct 20, 2021
@dagood dagood mentioned this issue Oct 20, 2021
Closed
@dseefeld dseefeld self-assigned this Oct 20, 2021
@dseefeld dseefeld mentioned this issue Oct 20, 2021
Merged
crummel added a commit to crummel/Microsoft_msbuild that referenced this issue Jan 13, 2022
@crummel
Restore building all TFMs for source-build
ceed7ca 
Required for omnisharp, nuget-client, templating, sdk

Background Issue: dotnet/source-build#2542
Patch removal issue: dotnet/source-build#2556
crummel pushed a commit to crummel/Microsoft_msbuild that referenced this issue Jan 13, 2022
@dseefeld @crummel
Remove dependency on MS.VS.Setup.Configuration.Interop
f1fdbcd 
Removes prebuilts.

Background Issue: dotnet/source-build#2542
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dseefeld dseefeld

Labels
area-prebuilts Reducing the number of prebuilt packages in the tarball
Projects
None yet
Milestone
6.0
Development

No branches or pull requests
3 participants
@dseefeld @MichaelSimons @dagood