Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK content differences - dotnet-format #3284

Closed
NikolaMilosavljevic opened this issue Mar 2, 2023 · 3 comments
Closed

SDK content differences - dotnet-format #3284

NikolaMilosavljevic opened this issue Mar 2, 2023 · 3 comments

Comments

@NikolaMilosavljevic
Copy link
Member

Microsoft and source-built SDKs contain the following differences related to dotnet-format content and packages. There should be no unintentional differences.

All intentional differences should be captured in SDK diff exclusion file: https://github.com/dotnet/installer/blob/main/src/SourceBuild/content/test/Microsoft.DotNet.SourceBuild.SmokeTests/assets/SdkDiffExclusions.txt

Files only present in Microsoft SDK:

./sdk/x.y.z/DotnetTools/dotnet-format/Microsoft.CodeAnalysis.Elfie.dll
./sdk/x.y.z/DotnetTools/dotnet-format/Microsoft.Win32.SystemEvents.dll
./sdk/x.y.z/DotnetTools/dotnet-format/runtimes/unix/lib/netx.y/System.Drawing.Common.dll
./sdk/x.y.z/DotnetTools/dotnet-format/runtimes/win/lib/netx.y/Microsoft.Win32.SystemEvents.dll
./sdk/x.y.z/DotnetTools/dotnet-format/runtimes/win/lib/netx.y/System.Drawing.Common.dll
./sdk/x.y.z/DotnetTools/dotnet-format/runtimes/win/lib/netx.y/System.Security.Cryptography.ProtectedData.dll
./sdk/x.y.z/DotnetTools/dotnet-format/runtimes/win/lib/netx.y/System.Windows.Extensions.dll
./sdk/x.y.z/DotnetTools/dotnet-format/System.Configuration.ConfigurationManager.dll
./sdk/x.y.z/DotnetTools/dotnet-format/System.Drawing.Common.dll
./sdk/x.y.z/DotnetTools/dotnet-format/System.Security.Cryptography.ProtectedData.dll
./sdk/x.y.z/DotnetTools/dotnet-format/System.Security.Permissions.dll
./sdk/x.y.z/DotnetTools/dotnet-format/System.Windows.Extensions.dll

Files only present in source-built SDK:

./sdk/x.y.z/DotnetTools/dotnet-format/System.Collections.Immutable.dll
./sdk/x.y.z/DotnetTools/dotnet-format/System.Diagnostics.DiagnosticSource.dll
./sdk/x.y.z/DotnetTools/dotnet-format/System.Reflection.Metadata.dll
./sdk/x.y.z/DotnetTools/dotnet-format/System.Text.Encoding.CodePages.dll
./sdk/x.y.z/DotnetTools/dotnet-format/System.Text.Encodings.Web.dll
./sdk/x.y.z/DotnetTools/dotnet-format/System.Text.Json.dll
./sdk/x.y.z/DotnetTools/dotnet-format/System.Threading.Channels.dll
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@MichaelSimons
Copy link
Member

There are two existing issues for differences in dotnet-format. I would like to track this work with them as the one in particular has some great analysis in it already.

@MichaelSimons
Copy link
Member

Link the two existing issues:

#2583
#2573

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants