Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Understand and eliminate all remaining SDK content differences #3291

Closed
NikolaMilosavljevic opened this issue Mar 2, 2023 · 4 comments
Closed
Assignees
Labels
area-testing Improvements in CI and testing

Comments

@NikolaMilosavljevic
Copy link
Member

NikolaMilosavljevic commented Mar 2, 2023

This is a master issue for tracking all remaining differences in SDK diff.

With dotnet/installer#15650, majority of differences are now captured in the exclusion file https://github.com/dotnet/installer/blob/main/src/SourceBuild/content/test/Microsoft.DotNet.SourceBuild.SmokeTests/assets/SdkDiffExclusions.txt. Each exclusion has an associated tracking issues.

There are more differences that need to be understood, properly tracked, and eventually eliminated. Most of the issues would require implementation by teams that own the particular binary or package. This issue should be updated with links to all dependent work in other repos, once owners are identified and issues created.

Categorized differences and associated issues:

The following files are .NET FX binaries showing in Microsoft-built SDK - not an issue for source-build:

./sdk/x.y.z/Microsoft.CodeCoverage.IO.dll
./sdk/x.y.z/Microsoft.VisualStudio.Setup.Configuration.Interop.dll
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@MichaelSimons
Copy link
Member

We should fix #3292 first as it will resolve at least one of these differences.

@MichaelSimons MichaelSimons moved this to 8.0 Preview 3 in .NET Source Build Mar 2, 2023
@MichaelSimons MichaelSimons added the area-testing Improvements in CI and testing label Mar 2, 2023
@MichaelSimons MichaelSimons moved this from 8.0 Preview 3 to 8.0 Backlog in .NET Source Build Mar 9, 2023
@MichaelSimons MichaelSimons moved this from Needs Review to 8.0 Backlog in .NET Source Build Jun 8, 2023
@MichaelSimons MichaelSimons moved this from 8.0 Backlog to 8.0 Preview 6 in .NET Source Build Jun 15, 2023
@NikolaMilosavljevic
Copy link
Member Author

The following files are .NET FX binaries showing in Microsoft-built SDK - not an issue for source-build:

./sdk/x.y.z/Microsoft.CodeCoverage.IO.dll
./sdk/x.y.z/Microsoft.VisualStudio.Setup.Configuration.Interop.dll

@MichaelSimons MichaelSimons moved this from 8.0 Preview 6 to In Progress in .NET Source Build Jun 21, 2023
@NikolaMilosavljevic
Copy link
Member Author

Completed.

@github-project-automation github-project-automation bot moved this from In Progress to Done in .NET Source Build Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-testing Improvements in CI and testing
Projects
Archived in project
Development

No branches or pull requests

2 participants