Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run CompareMsftToSb on non-msft SDK legs only #3292

Closed
MichaelSimons opened this issue Mar 2, 2023 · 4 comments
Closed

Run CompareMsftToSb on non-msft SDK legs only #3292

MichaelSimons opened this issue Mar 2, 2023 · 4 comments
Labels
area-testing Improvements in CI and testing

Comments

@MichaelSimons
Copy link
Member

Currently CI is running the CompareMsftToSb on the legs that build with the MSFT SDK. This is a source of some of the diffs as noted in #2583 (comment). We should refactor CI to only run on the bootstrap legs or the new leg running with a previous source-build SDK.

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@NikolaMilosavljevic
Copy link
Member

It doesn't seem that this will yield significant improvements in the quality of SDK diffs. I did a local test of stage 1 and stage 2 source-builds - there was only one difference/improvement in SDK diffs: ./sdk/x.y.z/dotnettools/dotnet-watch/x.y.z/tools/netx.y/any/system.io.pipelines.dll

@MichaelSimons MichaelSimons added area-testing Improvements in CI and testing and removed untriaged labels Mar 9, 2023
@MichaelSimons MichaelSimons moved this to 8.0 Backlog in .NET Source Build Mar 9, 2023
@MichaelSimons
Copy link
Member Author

[Triage] We should re-evaluate the value of this once we get closer to releasing 8.0. Even though only one assembly was removed in the latest assessment, in the future there may be more and having this change would save time in investigation. Hard to say what the value would be.

@MichaelSimons MichaelSimons moved this from Needs Review to 8.0 Preview 6 in .NET Source Build Jun 15, 2023
@NikolaMilosavljevic
Copy link
Member

I've compared 8.0 preview 7 SDKs produced in source-builds that were running with 1) Microsoft SDK, 2) previously source-built SDK, 3) current source-built SDK. There were no differences in content, so we can continue running CompareMsftToSb tests on legs using Microsoft SDK.

@github-project-automation github-project-automation bot moved this from 8.0 Preview 6 to Done in .NET Source Build Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-testing Improvements in CI and testing
Projects
Archived in project
Development

No branches or pull requests

2 participants