-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run CompareMsftToSb on non-msft SDK legs only #3292
Comments
I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label. |
It doesn't seem that this will yield significant improvements in the quality of SDK diffs. I did a local test of stage 1 and stage 2 source-builds - there was only one difference/improvement in SDK diffs: |
[Triage] We should re-evaluate the value of this once we get closer to releasing 8.0. Even though only one assembly was removed in the latest assessment, in the future there may be more and having this change would save time in investigation. Hard to say what the value would be. |
I've compared 8.0 preview 7 SDKs produced in source-builds that were running with 1) Microsoft SDK, 2) previously source-built SDK, 3) current source-built SDK. There were no differences in content, so we can continue running |
Currently CI is running the CompareMsftToSb on the legs that build with the MSFT SDK. This is a source of some of the diffs as noted in #2583 (comment). We should refactor CI to only run on the bootstrap legs or the new leg running with a previous source-build SDK.
The text was updated successfully, but these errors were encountered: