Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable dotnet-format tests on Alpine #3598

Closed
NikolaMilosavljevic opened this issue Aug 23, 2023 · 3 comments
Closed

Enable dotnet-format tests on Alpine #3598

NikolaMilosavljevic opened this issue Aug 23, 2023 · 3 comments
Assignees
@NikolaMilosavljevic
Labels
area-testing Improvements in CI and testing

Comments

@NikolaMilosavljevic
Copy link
Member

Dotnet-format tests on Alpine were disabled with dotnet/installer#17247 due to issue with dotnet-format tool on that platform - dotnet/format#1945

This was uncovered when we enabled those tests with dotnet/installer#17238
@dotnet-issue-labeler dotnet-issue-labeler bot added area-testing Improvements in CI and testing untriaged labels Aug 23, 2023
@MichaelSimons MichaelSimons moved this from Backlog to Blocked in .NET Source Build Aug 24, 2023
@MichaelSimons
Copy link
Member

@NikolaMilosavljevic - Is this now unblocked? It looks like the msbuildLocator changes were merged.

@NikolaMilosavljevic
Copy link
Member Author

@NikolaMilosavljevic - Is this now unblocked? It looks like the msbuildLocator changes were merged.

I'm going to confirm and reenable the tests.

@NikolaMilosavljevic NikolaMilosavljevic mentioned this issue Oct 19, 2023
Merged
@NikolaMilosavljevic
Copy link
Member Author

Fixed with dotnet/installer#17582

@github-project-automation github-project-automation bot moved this from Blocked to Done in .NET Source Build Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NikolaMilosavljevic NikolaMilosavljevic

Labels
area-testing Improvements in CI and testing
Projects
.NET Source Build
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MichaelSimons @NikolaMilosavljevic