Disable format tests on Alpine #17247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mthalman
approved these changes
Aug 24, 2023
| @@ -19,7 +19,7 @@ public class DotNetFormatTests : SmokeTests | |||
| /// <Summary> | |||
| /// Format an unformatted project and verify that the output matches the pre-computed solution. | |||
| /// </Summary> | |||
| [Fact] | |||
| [SkippableFact(Config.ExcludeDotnetFormatEnv, skipOnTrue: true)] | |||
There was a problem hiding this comment.
The disadvantage of this approach is that the test is going to fail by default when run on Alpine. This is going to impact our Alpine distro maintainer friends. An alternative approach is to utilize the Config.TargetRid and conditionally run the test based on if it contains "alpine". We do something similar for osx today - https://github.com/dotnet/dotnet/blob/main/test/Microsoft.DotNet.SourceBuild.SmokeTests/TestScenario.cs#L14
The other advantage of this approach is that I see this workaround as being temporary until the dotnet-format issue is resolved. Utilizing Config.TargetRid would be a more scoped change (only needing to touch one place in the code).
This was referenced Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Format tests were enabled with #17238 That PR uncovered the issues with dotnet-format on Alpine that is tracked with dotnet/format#1945
This change allows skipping of dotnet-format tests on Alpine and disables them in Alpine CI leg.