Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[smoke-tests] Sourcelink tests should verify all source-build symbols #3612

Closed
NikolaMilosavljevic opened this issue Sep 5, 2023 · 3 comments
Closed

[smoke-tests] Sourcelink tests should verify all source-build symbols #3612

NikolaMilosavljevic opened this issue Sep 5, 2023 · 3 comments
Assignees
@NikolaMilosavljevic
Labels
area-testing Improvements in CI and testing

Comments

@NikolaMilosavljevic
Copy link
Member

NikolaMilosavljevic commented Sep 5, 2023 •
edited
Loading

Related to #3052

Upcoming sourcelink tests are going to verify available symbols, from runtime symbols package: dotnet-runtime-symbols-[Version]-[RID].tar.gz

There is a pending work to make symbols from all repos available in unified source-build artifacts location. Once that work is done, sourcelink tests should be expanded to cover all symbols.
@dotnet-issue-labeler dotnet-issue-labeler bot added area-testing Improvements in CI and testing untriaged labels Sep 5, 2023
@NikolaMilosavljevic NikolaMilosavljevic mentioned this issue Sep 5, 2023
Merged
@MichaelSimons
Copy link
Member

This requires dotnet/arcade#14015 to be merged and rolled out first.

@MichaelSimons MichaelSimons moved this from Backlog to 8.0 GA in .NET Source Build Sep 7, 2023
@MichaelSimons
Copy link
Member

Once this is done, it should complete the managed portion of #3462.

@NikolaMilosavljevic NikolaMilosavljevic moved this from 8.0 GA to In Progress in .NET Source Build Oct 5, 2023
@NikolaMilosavljevic NikolaMilosavljevic mentioned this issue Oct 6, 2023
Merged
@NikolaMilosavljevic
Copy link
Member Author

Fixed with dotnet/installer#17477

@github-project-automation github-project-automation bot moved this from In Progress to Done in .NET Source Build Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NikolaMilosavljevic NikolaMilosavljevic

Labels
area-testing Improvements in CI and testing
Projects
.NET Source Build
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MichaelSimons @NikolaMilosavljevic