Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test to check that all managed/unmanaged debug symbols are available #3462

Closed
omajid opened this issue May 18, 2023 · 3 comments
Closed
Assignees
Labels
area-testing Improvements in CI and testing

Comments

@omajid
Copy link
Member

omajid commented May 18, 2023

When we build .NET via source-build, it produces a .NET SDK that includes full debug symbols - both managed and unmanaged.

We should have a test that verifies that this debug information is actually present for all managed and unmanaged binaries to avoid discovering this post-release.

Here's an example where we were producing a binary that is missing debug information. dotnet/sdk-container-builds#440

See also: #2543

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

omajid added a commit to omajid/dotnet-installer that referenced this issue May 23, 2023
This test runs `file` to find ELF binaries, and then `eu-readelf`
against it to find if all the indicators for native debug symbols are
present.

The technique was explained to me by Mark Wielaard ages ago.

This test currently fails. It will continue to fail until
dotnet/sdk-container-builds#440 is fixed.

Contributes to dotnet/source-build#3462
omajid added a commit to omajid/dotnet-installer that referenced this issue May 23, 2023
This test runs `file` to find ELF binaries, and then `eu-readelf`
against it to find if all the indicators for native debug symbols are
present.

The technique was explained to me by Mark Wielaard ages ago.

This test currently fails. It will continue to fail until
dotnet/sdk-container-builds#440 is fixed.

Contributes to dotnet/source-build#3462
@MichaelSimons MichaelSimons added area-testing Improvements in CI and testing and removed untriaged labels May 25, 2023
@MichaelSimons MichaelSimons moved this to In Progress in .NET Source Build May 25, 2023
omajid added a commit to omajid/dotnet-installer that referenced this issue May 26, 2023
This test runs `file` to find ELF binaries, and then `eu-readelf`
against it to find if all the indicators for native debug symbols are
present.

The technique was explained to me by Mark Wielaard ages ago.

This test currently fails. It will continue to fail until
dotnet/sdk-container-builds#440 is fixed.

Contributes to dotnet/source-build#3462
omajid added a commit to omajid/dotnet-installer that referenced this issue Jun 1, 2023
This test runs `file` to find ELF binaries, and then `eu-readelf`
against it to find if all the indicators for native debug symbols are
present.

The technique was explained to me by Mark Wielaard ages ago.

This test currently fails. It will continue to fail until
dotnet/sdk-container-builds#440 is fixed.

Contributes to dotnet/source-build#3462
omajid added a commit to omajid/dotnet-installer that referenced this issue Jun 1, 2023
This test runs `file` to find ELF binaries, and then `eu-readelf`
against it to find if all the indicators for native debug symbols are
present.

The technique was explained to me by Mark Wielaard ages ago.

This test currently fails. It will continue to fail until
dotnet/sdk-container-builds#440 is fixed.

Contributes to dotnet/source-build#3462
omajid added a commit to omajid/dotnet-installer that referenced this issue Jun 1, 2023
This test runs `file` to find ELF binaries, and then `eu-readelf`
against it to find if all the indicators for native debug symbols are
present.

The technique was explained to me by Mark Wielaard ages ago.

This test currently fails. It will continue to fail until
dotnet/sdk-container-builds#440 is fixed.

Contributes to dotnet/source-build#3462
omajid added a commit to omajid/dotnet-installer that referenced this issue Jun 1, 2023
This test runs `file` to find ELF binaries, and then `eu-readelf`
against it to find if all the indicators for native debug symbols are
present.

The technique was explained to me by Mark Wielaard ages ago.

This test currently fails. It will continue to fail until
dotnet/sdk-container-builds#440 is fixed.

Contributes to dotnet/source-build#3462
omajid added a commit to omajid/dotnet-installer that referenced this issue Jun 2, 2023
This test runs `file` to find ELF binaries, and then `eu-readelf`
against it to find if all the indicators for native debug symbols are
present.

The technique was explained to me by Mark Wielaard ages ago.

This test currently fails. It will continue to fail until
dotnet/sdk-container-builds#440 is fixed.

Contributes to dotnet/source-build#3462
omajid added a commit to omajid/dotnet-installer that referenced this issue Jun 6, 2023
This test runs `file` to find ELF binaries, and then `eu-readelf`
against it to find if all the indicators for native debug symbols are
present.

The technique was explained to me by Mark Wielaard ages ago.

This test currently fails. It will continue to fail until
dotnet/sdk-container-builds#440 is fixed.

Contributes to dotnet/source-build#3462
omajid added a commit to omajid/dotnet-installer that referenced this issue Jun 6, 2023
This test runs `file` to find ELF binaries, and then `eu-readelf`
against it to find if all the indicators for native debug symbols are
present.

The technique was explained to me by Mark Wielaard ages ago.

This test currently fails. It will continue to fail until
dotnet/sdk-container-builds#440 is fixed.

Contributes to dotnet/source-build#3462
omajid added a commit to omajid/dotnet-installer that referenced this issue Jun 6, 2023
This test runs `file` to find ELF binaries, and then `eu-readelf`
against it to find if all the indicators for native debug symbols are
present.

The technique was explained to me by Mark Wielaard ages ago.

This test currently fails. It will continue to fail until
dotnet/sdk-container-builds#440 is fixed.

Contributes to dotnet/source-build#3462
omajid added a commit to omajid/dotnet-installer that referenced this issue Jun 6, 2023
This test runs `file` to find ELF binaries, and then `eu-readelf`
against it to find if all the indicators for native debug symbols are
present.

The technique was explained to me by Mark Wielaard ages ago.

This test currently fails. It will continue to fail until
dotnet/sdk-container-builds#440 is fixed.

Contributes to dotnet/source-build#3462
omajid added a commit to omajid/dotnet-installer that referenced this issue Jun 7, 2023
This test runs `file` to find ELF binaries, and then `eu-readelf`
against it to find if all the indicators for native debug symbols are
present.

The technique was explained to me by Mark Wielaard ages ago.

This test currently fails. It will continue to fail until
dotnet/sdk-container-builds#440 is fixed.

Contributes to dotnet/source-build#3462
omajid added a commit to omajid/dotnet-installer that referenced this issue Jun 12, 2023
This test runs `file` to find ELF binaries, and then `eu-readelf`
against it to find if all the indicators for native debug symbols are
present.

The technique was explained to me by Mark Wielaard ages ago.

This test currently fails. It will continue to fail until
dotnet/sdk-container-builds#440 is fixed.

Contributes to dotnet/source-build#3462
omajid added a commit to omajid/dotnet-installer that referenced this issue Jul 13, 2023
This test runs `file` to find ELF binaries, and then `eu-readelf`
against it to find if all the indicators for native debug symbols are
present.

The technique was explained to me by Mark Wielaard ages ago.

This test currently fails. It will continue to fail until
dotnet/sdk-container-builds#440 is fixed.

Contributes to dotnet/source-build#3462
omajid added a commit to omajid/dotnet-installer that referenced this issue Jul 17, 2023
This test runs `file` to find ELF binaries, and then `eu-readelf`
against it to find if all the indicators for native debug symbols are
present.

The technique was explained to me by Mark Wielaard ages ago.

This test currently fails. It will continue to fail until
dotnet/sdk-container-builds#440 is fixed.

Contributes to dotnet/source-build#3462
omajid added a commit to omajid/dotnet-installer that referenced this issue Jul 19, 2023
This test runs `file` to find ELF binaries, and then `eu-readelf`
against it to find if all the indicators for native debug symbols are
present.

The technique was explained to me by Mark Wielaard ages ago.

This test currently fails. It will continue to fail until
dotnet/sdk-container-builds#440 is fixed.

Contributes to dotnet/source-build#3462
omajid added a commit to omajid/dotnet-installer that referenced this issue Aug 8, 2023
This test runs `file` to find ELF binaries, and then `eu-readelf`
against it to find if all the indicators for native debug symbols are
present.

The technique was explained to me by Mark Wielaard ages ago.

This test currently fails. It will continue to fail until
dotnet/sdk-container-builds#440 is fixed.

Contributes to dotnet/source-build#3462
@omajid
Copy link
Member Author

omajid commented Oct 19, 2023

Can we close this issue now?

@MichaelSimons
Copy link
Member

Can we close this issue now?

Yes - Thanks to both @omajid and @NikolaMilosavljevic for the test contributions.

@github-project-automation github-project-automation bot moved this from In Progress to Done in .NET Source Build Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-testing Improvements in CI and testing
Projects
Archived in project
Development

No branches or pull requests

2 participants