Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VMR output and intermediate directory names need a rework #3696

Closed
mmitche opened this issue Oct 27, 2023 · 3 comments · Fixed by dotnet/installer#18591
Closed

VMR output and intermediate directory names need a rework #3696

mmitche opened this issue Oct 27, 2023 · 3 comments · Fixed by dotnet/installer#18591

Comments

@mmitche
Copy link
Member

mmitche commented Oct 27, 2023

Describe the Bug

When working on a cross-build for Linux, @directhex noted that the blob feed and artifacts directories still specify x64: #3671 (comment). We should rework these directory names.

Steps to Reproduce

See #3671 (comment) for info.

Other Information

My guess is that the target arch should be in the name of the directory, rather than the host. Furthermore, it may make sense to change 'blob-feed' to something meaningful (intermediate-assets?). 'blob-feed' refers to a bit of ancient technology we used to use for NuGet feeds in the 2.1 timeframe (Sleet).

T-Shirt size: XS

@mmitche
Copy link
Member Author

mmitche commented Jan 3, 2024

T-Shirt size: Small, not critical

These changes should be relatively simple?

@ViktorHofer
Copy link
Member

Note that TargetArchitecture is already encoded in the directory name. I think this issue comes from not using the GNU terms correctly in the various repositories and now also having a OverrideTargetOS setting. We should simplify those various models. I expect the folder structure to be automatically fixed when doing that.

Overall I agree that what this issue tracks is not critical and just a cosmetic change.

@ViktorHofer
Copy link
Member

I think it would make sense to sit down with @directhex and some others to discuss all the OS and arch properties that we plan to pass in. @mmitche has a proposal for source build controls and while that's great for all the various source build specifics, I see value in having a separate discussion about the OS and arch combinations especially to support cross builds.

Here's what I implemented for the Windows PoC: https://github.com/dotnet/dotnet/blob/37cd6b020dda102b265ff62577a02f580230fa21/Directory.Build.props#L8-L54

ViktorHofer added a commit to dotnet/installer that referenced this issue Feb 9, 2024
1. Shipping and non-shipping artifacts to Arcade default locations:
-> artifacts/packages/<config>/Shipping
-> artifacts/packages/<config>/NonShipping

Add the local feed for the addition package directory to NuGet.config
Remove the non-shipping packages list generation now that artifacts
are grouped.

2. Genereated the intermediate PackageVersions* files in
-> artifacts/obj/PackageVersions

3. Extract the repo symbol archives intermediates to
-> artifacts/obj/Symbols/

4. Sequence targets better and apply correct DependsOnTargets

5. Small clean-up

Fixes dotnet/source-build#4104
Fixes dotnet/source-build#3696
ViktorHofer added a commit to dotnet/installer that referenced this issue Feb 9, 2024
1. Shipping and non-shipping artifacts to Arcade default locations:
-> artifacts/packages/<config>/Shipping
-> artifacts/packages/<config>/NonShipping

Add the local feed for the addition package directory to NuGet.config
Remove the non-shipping packages list generation now that artifacts
are grouped.

2. Genereated the intermediate PackageVersions* files in
-> artifacts/obj/PackageVersions

3. Extract the repo symbol archives intermediates to
-> artifacts/obj/Symbols/

4. Sequence targets better and apply correct DependsOnTargets

5. Small clean-up

Fixes dotnet/source-build#4104
Fixes dotnet/source-build#3696
ViktorHofer added a commit to dotnet/installer that referenced this issue Feb 9, 2024
1. Shipping and non-shipping artifacts to Arcade default locations:
-> artifacts/packages/<config>/Shipping
-> artifacts/packages/<config>/NonShipping

Add the local feed for the addition package directory to NuGet.config
Remove the non-shipping packages list generation now that artifacts
are grouped.

2. Genereated the intermediate PackageVersions* files in
-> artifacts/obj/PackageVersions

3. Extract the repo symbol archives intermediates to
-> artifacts/obj/Symbols/

4. Sequence targets better and apply correct DependsOnTargets

5. Small clean-up

Fixes dotnet/source-build#4104
Fixes dotnet/source-build#3696
ViktorHofer added a commit to dotnet/installer that referenced this issue Feb 9, 2024
1. Shipping and non-shipping artifacts to Arcade default locations:
-> artifacts/packages/<config>/Shipping
-> artifacts/packages/<config>/NonShipping

Add the local feed for the addition package directory to NuGet.config
Remove the non-shipping packages list generation now that artifacts
are grouped.

2. Genereated the intermediate PackageVersions* files in
-> artifacts/obj/PackageVersions

3. Extract the repo symbol archives intermediates to
-> artifacts/obj/Symbols/

4. Sequence targets better and apply correct DependsOnTargets

5. Small clean-up

Fixes dotnet/source-build#4104
Fixes dotnet/source-build#3696
ViktorHofer added a commit to dotnet/installer that referenced this issue Feb 9, 2024
1. Shipping and non-shipping artifacts to Arcade default locations:
-> artifacts/packages/<config>/Shipping
-> artifacts/packages/<config>/NonShipping

Add the local feed for the addition package directory to NuGet.config
Remove the non-shipping packages list generation now that artifacts
are grouped.

2. Genereated the intermediate PackageVersions* files in
-> artifacts/obj/PackageVersions

3. Extract the repo symbol archives intermediates to
-> artifacts/obj/Symbols/

4. Sequence targets better and apply correct DependsOnTargets

5. Small clean-up

Fixes dotnet/source-build#4104
Fixes dotnet/source-build#3696
ViktorHofer added a commit to dotnet/installer that referenced this issue Feb 9, 2024
1. Shipping and non-shipping artifacts to Arcade default locations:
-> artifacts/packages/<config>/Shipping
-> artifacts/packages/<config>/NonShipping

Add the local feed for the addition package directory to NuGet.config
Remove the non-shipping packages list generation now that artifacts
are grouped.

2. Genereated the intermediate PackageVersions* files in
-> artifacts/obj/PackageVersions

3. Extract the repo symbol archives intermediates to
-> artifacts/obj/Symbols/

4. Sequence targets better and apply correct DependsOnTargets

5. Small clean-up

Fixes dotnet/source-build#4104
Fixes dotnet/source-build#3696
ViktorHofer added a commit to dotnet/installer that referenced this issue Feb 9, 2024
1. Shipping and non-shipping artifacts to Arcade default locations:
-> artifacts/packages/<config>/Shipping
-> artifacts/packages/<config>/NonShipping

Add the local feed for the addition package directory to NuGet.config
Remove the non-shipping packages list generation now that artifacts
are grouped.

2. Genereated the intermediate PackageVersions* files in
-> artifacts/obj/PackageVersions

3. Extract the repo symbol archives intermediates to
-> artifacts/obj/Symbols/

4. Sequence targets better and apply correct DependsOnTargets

5. Small clean-up

Fixes dotnet/source-build#4104
Fixes dotnet/source-build#3696
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants