Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VMR][mono] Check in AOT offsets file(s), remove offsets jobs from official build #3701

Closed
3 tasks done
steveisok opened this issue Oct 31, 2023 · 2 comments · Fixed by dotnet/runtime#109612
Closed
3 tasks done

[VMR][mono] Check in AOT offsets file(s), remove offsets jobs from official build #3701

steveisok opened this issue Oct 31, 2023 · 2 comments · Fixed by dotnet/runtime#109612
Assignees
@akoeplinger
Labels
area-unified-build

Comments

@steveisok
Copy link
Member

steveisok commented Oct 31, 2023 •
edited by akoeplinger
Loading

In the runtime official build, the first step in building mono cross compilers requires generating offset files in a separate job and is later consumed in another job that produces the binaries. This approach makes a VMR vertical build more difficult because we cannot express "build all artifacts for linux-arm64" in one go without depending on a separate job.

  • Produce offset files locally and check them into the runtime repo
  • Adjust build to pick them up from the source tree instead of where azdo places them now
  • Add some kind of validation job to make sure the offset files are up to date
@dotnet-issue-labeler dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@steveisok steveisok moved this to In Progress in .NET Unified Build Nov 15, 2023
@mmitche
Copy link
Member

mmitche commented Jan 23, 2024

@akoeplinger What's the status of this?

@tkapin tkapin moved this from In Progress to Ready in .NET Unified Build Feb 1, 2024
@akoeplinger akoeplinger moved this from Ready to In Progress in .NET Unified Build Feb 15, 2024
This was referenced Mar 5, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
akoeplinger added a commit to akoeplinger/runtime that referenced this issue Nov 7, 2024
@akoeplinger
[mono] Check in offsets files used for AOT cross compilers
c151236 
This allows us to remove a join point in the VMR build.
Instead of generating the offsets during the AOT cross compiler build we use the checked in files and change the existing CI job to validate that the generated file matches the checked in ones.

Fixes dotnet/source-build#3701
akoeplinger added a commit to akoeplinger/runtime that referenced this issue Nov 7, 2024
@akoeplinger
[mono] Check in offsets files used for AOT cross compilers
7b0c97b 
This allows us to remove a join point in the VMR build.
Instead of generating the offsets during the AOT cross compiler build we use the checked in files and change the existing CI job to validate that the generated file matches the checked in ones.

Fixes dotnet/source-build#3701
@akoeplinger akoeplinger mentioned this issue Nov 7, 2024
Merged
akoeplinger added a commit to akoeplinger/runtime that referenced this issue Nov 7, 2024
@akoeplinger
[mono] Check in offsets files used for AOT cross compilers
b349128 
This allows us to remove a join point in the VMR build.
Instead of generating the offsets during the AOT cross compiler build we use the checked in files and change the existing CI job to validate that the generated file matches the checked in ones.

Fixes dotnet/source-build#3701
@github-project-automation github-project-automation bot moved this from In Progress to Done in .NET Unified Build Nov 8, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in .NET Source Build Nov 8, 2024
mikelle-rogers pushed a commit to mikelle-rogers/runtime that referenced this issue Dec 10, 2024
@akoeplinger @mikelle-rogers
[mono] Check in offsets files used for AOT cross compilers (dotnet#10…
dc106ae 
…9612)

This allows us to remove a join point in the VMR build.
Instead of generating the offsets during the AOT cross compiler build we use the checked in files and change the existing CI job to validate that the generated file matches the checked in ones.

Fixes dotnet/source-build#3701
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akoeplinger akoeplinger

Labels
area-unified-build
Projects
.NET Source Build
Archived in project
.NET Unified Build
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[mono] Check in offsets files used for AOT cross compilers akoeplinger/runtime
4 participants
@steveisok @akoeplinger @MichaelSimons @mmitche