-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify publishing infrastructure in runtime #4239
Labels
Comments
This was referenced Mar 19, 2024
@NikolaMilosavljevic - Is this something on your radar to pick up or is this something someone else is going to do? Maybe @ViktorHofer? |
This might need to wait for in build signing. At least some part of it could be done already now. dotnet/runtime#100004 is related. I will assign this issue to myself. |
jkoritzinsky
added a commit
to jkoritzinsky/runtime
that referenced
this issue
Oct 17, 2024
Fixes dotnet/source-build#4239 Replaces dotnet#100004 Co-authored By: Viktor Hofer <viktor.hofer@microsoft.com>
ViktorHofer
pushed a commit
to dotnet/runtime
that referenced
this issue
Oct 23, 2024
* Unify dotnet/runtime on using Arcade -publish Fixes dotnet/source-build#4239 Replaces #100004 Co-authored By: Viktor Hofer <viktor.hofer@microsoft.com> * Use DotNetBuildOrchestrator to avoid executing in a repo source-build context. * Actually, we want this logic to run only when we're running in a non-VMR-like context, even repo build. * Restore, but only restore the toolset in the publish job * Fix Exists check and do the "restore toolset only" check one degree away from the Arcade SDK. * Set the "publish using pipelines" global property when publishing * Don't produce the product version files on repo source build.
mikelle-rogers
pushed a commit
to mikelle-rogers/runtime
that referenced
this issue
Dec 10, 2024
* Unify dotnet/runtime on using Arcade -publish Fixes dotnet/source-build#4239 Replaces dotnet#100004 Co-authored By: Viktor Hofer <viktor.hofer@microsoft.com> * Use DotNetBuildOrchestrator to avoid executing in a repo source-build context. * Actually, we want this logic to run only when we're running in a non-VMR-like context, even repo build. * Restore, but only restore the toolset in the publish job * Fix Exists check and do the "restore toolset only" check one degree away from the Arcade SDK. * Set the "publish using pipelines" global property when publishing * Don't produce the product version files on repo source build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See discussion in #4101 (comment)
Runtime is the remaining repository that publishes differently when building the repo in isolation versus when building inside the VMR. The VMR publishing is also missing some artifacts, i.e. checksums, version files and potentially more.
This item tracks getting rid of
prepare-artifacts.proj
in runtime and using the Arcade publish entry-point. Presumably this just means following the already established process from windowsdesktop and deployment-tools: dotnet/windowsdesktop#4251The text was updated successfully, but these errors were encountered: