Skip to content

Build (just) the sdk bundle in sdk BuildPass=2 for win-x64, win-x86, win-arm64 #4777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #3739
ViktorHofer opened this issue Dec 2, 2024 · 0 comments · Fixed by dotnet/sdk#47397
Closed
Tracked by #3739

Build (just) the sdk bundle in sdk BuildPass=2 for win-x64, win-x86, win-arm64 #4777

ViktorHofer opened this issue Dec 2, 2024 · 0 comments · Fixed by dotnet/sdk#47397
Assignees
@ViktorHofer
Labels
area-unified-build

Comments

@ViktorHofer
Copy link
Member

When building the sdk installers in BuildPass=2 on Windows (as they depend on join assets from different verticals) the redist-installers.csproj project needs to be referenced in the repo's Build.props file. This causes the entire archive to be built again which is throw-away work and results in duplicate assets when merged and uploading everything. This is especially important as that logic will run in a BuildPass leg which means that it's on the critical path from a build time perspective.

It should be possible to encapsulate the logic that is responsible for creating the installers in dotnet/sdk and only invoke that.
@dotnet-issue-labeler dotnet-issue-labeler bot added area-build Improvements in source-build's own build process untriaged labels Dec 2, 2024
@ViktorHofer ViktorHofer self-assigned this Dec 2, 2024
@ViktorHofer ViktorHofer removed area-build Improvements in source-build's own build process untriaged labels Dec 2, 2024
@ViktorHofer ViktorHofer mentioned this issue Dec 2, 2024
Merged
@MichaelSimons MichaelSimons moved this to In Progress in .NET Unified Build Jan 14, 2025
@ViktorHofer ViktorHofer mentioned this issue Jan 22, 2025
Closed
@ViktorHofer ViktorHofer changed the title Allow building just the sdk installers in dotnet/sdk Build (just) the sdk bundle in sdk BuildPass=2 win-x64, win-x86, win-arm64 Feb 25, 2025
@ViktorHofer ViktorHofer changed the title Build (just) the sdk bundle in sdk BuildPass=2 win-x64, win-x86, win-arm64 Build (just) the sdk bundle in sdk BuildPass=2 for win-x64, win-x86, win-arm64 Feb 25, 2025
@ViktorHofer ViktorHofer mentioned this issue Feb 13, 2025
Closed
13 tasks
ViktorHofer added a commit to ViktorHofer/sdk that referenced this issue Mar 9, 2025
@ViktorHofer
Generate the sdk msi bundles inside the VMR on windows BuildPass=2 ve…
ec1f36f 
…rticals

Fixes dotnet/source-build#4777

The msi bundle depends on artifacts from other windows verticals.
Therefore, it needs to be generated in a BuildPass=2 vertical in the VMR.

Update the existing BuildPass2 verticals and add the win-arm64 one.
Update the logic to set a Boolean property that decides whether
only the sdk bundle should be generated in redist-installer.proj.

Update existing code so that GenerateMsis.targets doesn't not depend
on other targets files aside form the newly introduce RestoreLayout.targets.
@ViktorHofer ViktorHofer mentioned this issue Mar 9, 2025
Merged
@github-project-automation github-project-automation bot moved this from In Progress to Done in .NET Unified Build Mar 12, 2025
@github-project-automation github-project-automation bot moved this from Backlog to Done in .NET Source Build Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ViktorHofer ViktorHofer

Labels
area-unified-build
Projects
.NET Source Build
Archived in project
.NET Unified Build
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Generate the sdk msi bundles inside the VMR on windows BuildPass=2 verticals ViktorHofer/sdk
2 participants
@ViktorHofer @MichaelSimons