Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical manifest in artifacts tarball does not have a known name #4807

Closed
mthalman opened this issue Dec 18, 2024 · 0 comments · Fixed by dotnet/sdk#45554
Closed

Vertical manifest in artifacts tarball does not have a known name #4807

mthalman opened this issue Dec 18, 2024 · 0 comments · Fixed by dotnet/sdk#45554

Comments

@mthalman
Copy link
Member

The changes in dotnet/sdk#43627 caused the vertical manifest, which previously had a well-known name of VerticalManifest.xml, to have a name that is based on the job name which produced that file. This causes issues when consuming the artifacts tarball as the previously source built artifacts for source build. That relies on knowing the file name to retrieve: https://github.com/dotnet/sdk/blob/77d763f12701c985bad0a6ed6bbba4c9e7b1c8cb/src/SourceBuild/content/repo-projects/Directory.Build.targets#L303.

By not having the vertical manifest file, the previous package versions don't get populated, preventing the build from being able to use any of the packages from the previously source built artifacts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant