core-sdk: Add target rid to AppHostRuntimeIdentifiers #1448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @nguerrera @dagood @crummel @omajid @dseefeld Also verified this one against core-sdk repo. |
tmds
commented
Jan 16, 2020
| AppHostPackNamePattern="Microsoft.NETCore.App.Host.**RID**" | ||
| AppHostPackVersion="$(_NETCoreAppPackageVersion)" | ||
| - AppHostRuntimeIdentifiers="@(NetCoreRuntimePackRids, '%3B')" | ||
| + AppHostRuntimeIdentifiers="@(NetCoreAppHostPackRids, '%3B')" |
There was a problem hiding this comment.
This is the change for 3.1.
It's possible there is an apphost also for 3.0 (from installing the 3.0 sdk), but we can't add it to the 3.0 AppHostRuntimeIdentifiers because that would cause a failure in case it isn't installed.
We could make the sdk look into the packs folder so it can figure out itself what apphosts are available locally. Then we don't have to add them explicitly here either.
crummel
approved these changes
Jan 16, 2020
adaggarwal
approved these changes
Jan 16, 2020
dseefeld
approved these changes
Jan 17, 2020
|
Thanks Tom! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1444 for 3.1