Fix hardcoded FEATURE_DISTRO_AGNOSTIC_SSL

[omajid]

This is a fix for dotnet/runtime#41768

[omajid]

cc @tmds

[dagood]

macOS error is a homebrew issue, fixed here: Homebrew/homebrew-cask-versions#9633. (I hit retry in case you wanted to run this on macOS too to see if it regresses there.)

[omajid]

I just realized that this doesn't handle the case where FEATURE_DISTRO_AGNOSTIC_SSL is defined... because it's never defined in the installer configuration, only in libraries 😢

[omajid]

dotnet/runtime PR: dotnet/runtime#42415

[omajid]

The dotnet/runtime PR was merged, into master EDIT: I misread the state. It's still in review. But it's still targeted for master.

That means this wont be a part of 5.0 GA, right? What's the best thing to do from a source-build point of view now? Should we get this PR merged or do something else?

[dagood]

That means this wont be a part of 5.0 GA, right?

Yeah, my understanding is master is solidly 6.0 at this point, no automatic backporting.

What's the best thing to do from a source-build point of view now? Should we get this PR merged or do something else?

I think that we should get this patch in to make sure it keeps building correctly in dotnet/source-build up to 5.0 GA no matter what. Then we can remove it naturally once it gets ported to 5.0 (whether that's before or after GA).

I think there's just the one nit from the dotnet/runtime PR to bring back here, the message. I think we should put a link to the dotnet/runtime PR in the patch description to make it easy to navigate later. (E.g. if it's auto-applied, show up nicely in the commit message.) Then I think it's good to go.

@crummel @dseefeld

[omajid]

I had to manually massage these few lines for the patch to apply. These were changed between Preview 8 and master.